Skip to content

reenable db tests (ffs) #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MeijisIrlnd merged 1 commit into from
Nov 29, 2025
Merged

reenable db tests (ffs) #78

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
198 changes: 99 additions & 99 deletions tests/data/mostlyharmless_DatabaseStateTests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,104 +8,104 @@
#include <catch2/matchers/catch_matchers_floating_point.hpp>

namespace mostly_harmless::testing {
// template <bool ShouldSucceed>
// auto tryCreateDatabase(const std::filesystem::path& destination, const std::vector<std::pair<std::string, data::DatabaseValueVariant>>& initialValues) -> std::optional<data::DatabaseState> {
// auto databaseOpt = data::DatabaseState::tryCreate(destination, initialValues);
// if constexpr (!ShouldSucceed) {
// REQUIRE(!databaseOpt);
// return {};
// } else {
// REQUIRE(databaseOpt);
// return databaseOpt;
// }
// }
//
// TEST_CASE("Test DatabaseState") {
// auto tempDir = utils::directories::getDirectory(utils::directories::DirectoryType::Temp);
// if (!tempDir) {
// REQUIRE(false);
// }
// auto dbFile = *tempDir / "moha_test_db.sqlite";
// SECTION("Test Valid Location, with no initial values") {
// {
// auto databaseOpt = tryCreateDatabase<true>(dbFile, {});
// auto& database = *databaseOpt;
// REQUIRE_NOTHROW(database.set<std::string>("Hello", "World"));
// const auto retrieved = database.get<std::string>("Hello");
// REQUIRE(retrieved.has_value());
// REQUIRE(*retrieved == "World");
// REQUIRE(!database.get<int>("aaaaa"));
// }
// {
// std::vector<std::pair<std::string, data::DatabaseValueVariant>> initialValues;
// initialValues.emplace_back("IntTest", 10);
// initialValues.emplace_back("DoubleTest", 15.0);
// auto databaseOpt = tryCreateDatabase<true>(dbFile, initialValues);
// auto& database = *databaseOpt;
// auto retrievedDouble = database.get<double>("DoubleTest");
// REQUIRE(retrievedDouble.has_value());
// REQUIRE_THAT(retrievedDouble.value(), Catch::Matchers::WithinRel(15.0));
// database.set<double>("DoubleTest", 20.0);
// retrievedDouble = database.get<double>("DoubleTest");
// REQUIRE(retrievedDouble.has_value());
// REQUIRE_THAT(retrievedDouble.value(), Catch::Matchers::WithinRel(20.0));
// auto database2Opt = tryCreateDatabase<true>(dbFile, initialValues);
// auto& database2 = *database2Opt;
// retrievedDouble = database2.get<double>("DoubleTest");
// REQUIRE(retrievedDouble.has_value());
// REQUIRE_THAT(retrievedDouble.value(), Catch::Matchers::WithinRel(20.0));
// }
//
// std::filesystem::remove(dbFile);
// }
//
// SECTION("Test Invalid Location") {
// tryCreateDatabase<false>("INVALID LOCATION", {});
// }
// SECTION("Test In-Memory") {
// tryCreateDatabase<true>(":memory:", {});
// }
//
// SECTION("Test Duplicate") {
// {
// auto connectionAOpt = tryCreateDatabase<true>(dbFile, { { "test", "aaaa" } });
// auto& databaseA = *connectionAOpt;
// auto connectionBOpt = databaseA.duplicate();
// REQUIRE(connectionBOpt.has_value());
// auto& databaseB = *connectionBOpt;
// auto retrievalOpt = databaseB.get<std::string>("test");
// REQUIRE(retrievalOpt.has_value());
// REQUIRE(*retrievalOpt == "aaaa");
// }
// std::filesystem::remove(dbFile);
// }
//
// SECTION("Test DatabasePropertyWatcher") {
// for (auto i = 0; i < 100; ++i) {
// {
// auto databaseOpt = tryCreateDatabase<true>(dbFile, { { "test", 0 } });
// auto& database = *databaseOpt;
// std::atomic<bool> wasPropertyChanged{ false };
// std::atomic<int> newValue{ 0 };
// {
// auto onPropertyChanged = [&wasPropertyChanged, &newValue](const auto& x) -> void {
// wasPropertyChanged.store(true);
// newValue = x;
// };
// auto listener = data::DatabasePropertyWatcher<int>::tryCreate(database, "test", 1, std::move(onPropertyChanged));
// REQUIRE(listener);
// database.set<int>("test", 10);
// std::this_thread::sleep_for(std::chrono::milliseconds(50));
// REQUIRE(wasPropertyChanged.load());
// database.set<int>("test", 20);
// std::this_thread::sleep_for(std::chrono::milliseconds(50));
// REQUIRE(newValue == 20);
// database.set<int>("test", 30);
// }
// }
// std::filesystem::remove(dbFile);
// }
// }
// }
template <bool ShouldSucceed>
auto tryCreateDatabase(const std::filesystem::path& destination, const std::vector<std::pair<std::string, data::DatabaseValueVariant>>& initialValues) -> std::optional<data::DatabaseState> {
auto databaseOpt = data::DatabaseState::tryCreate(destination, initialValues);
if constexpr (!ShouldSucceed) {
REQUIRE(!databaseOpt);
return {};
} else {
REQUIRE(databaseOpt);
return databaseOpt;
}
}

TEST_CASE("Test DatabaseState") {
auto tempDir = utils::directories::getDirectory(utils::directories::DirectoryType::Temp);
if (!tempDir) {
REQUIRE(false);
}
auto dbFile = *tempDir / "moha_test_db.sqlite";
SECTION("Test Valid Location, with no initial values") {
{
auto databaseOpt = tryCreateDatabase<true>(dbFile, {});
auto& database = *databaseOpt;
REQUIRE_NOTHROW(database.set<std::string>("Hello", "World"));
const auto retrieved = database.get<std::string>("Hello");
REQUIRE(retrieved.has_value());
REQUIRE(*retrieved == "World");
REQUIRE(!database.get<int>("aaaaa"));
}
{
std::vector<std::pair<std::string, data::DatabaseValueVariant>> initialValues;
initialValues.emplace_back("IntTest", 10);
initialValues.emplace_back("DoubleTest", 15.0);
auto databaseOpt = tryCreateDatabase<true>(dbFile, initialValues);
auto& database = *databaseOpt;
auto retrievedDouble = database.get<double>("DoubleTest");
REQUIRE(retrievedDouble.has_value());
REQUIRE_THAT(retrievedDouble.value(), Catch::Matchers::WithinRel(15.0));
database.set<double>("DoubleTest", 20.0);
retrievedDouble = database.get<double>("DoubleTest");
REQUIRE(retrievedDouble.has_value());
REQUIRE_THAT(retrievedDouble.value(), Catch::Matchers::WithinRel(20.0));
auto database2Opt = tryCreateDatabase<true>(dbFile, initialValues);
auto& database2 = *database2Opt;
retrievedDouble = database2.get<double>("DoubleTest");
REQUIRE(retrievedDouble.has_value());
REQUIRE_THAT(retrievedDouble.value(), Catch::Matchers::WithinRel(20.0));
}

std::filesystem::remove(dbFile);
}

SECTION("Test Invalid Location") {
tryCreateDatabase<false>("INVALID LOCATION", {});
}
SECTION("Test In-Memory") {
tryCreateDatabase<true>(":memory:", {});
}

SECTION("Test Duplicate") {
{
auto connectionAOpt = tryCreateDatabase<true>(dbFile, { { "test", "aaaa" } });
auto& databaseA = *connectionAOpt;
auto connectionBOpt = databaseA.duplicate();
REQUIRE(connectionBOpt.has_value());
auto& databaseB = *connectionBOpt;
auto retrievalOpt = databaseB.get<std::string>("test");
REQUIRE(retrievalOpt.has_value());
REQUIRE(*retrievalOpt == "aaaa");
}
std::filesystem::remove(dbFile);
}

SECTION("Test DatabasePropertyWatcher") {
for (auto i = 0; i < 100; ++i) {
{
auto databaseOpt = tryCreateDatabase<true>(dbFile, { { "test", 0 } });
auto& database = *databaseOpt;
std::atomic<bool> wasPropertyChanged{ false };
std::atomic<int> newValue{ 0 };
{
auto onPropertyChanged = [&wasPropertyChanged, &newValue](const auto& x) -> void {
wasPropertyChanged.store(true);
newValue = x;
};
auto listener = data::DatabasePropertyWatcher<int>::tryCreate(database, "test", 1, std::move(onPropertyChanged));
REQUIRE(listener);
database.set<int>("test", 10);
std::this_thread::sleep_for(std::chrono::milliseconds(50));
REQUIRE(wasPropertyChanged.load());
database.set<int>("test", 20);
std::this_thread::sleep_for(std::chrono::milliseconds(50));
REQUIRE(newValue == 20);
database.set<int>("test", 30);
}
}
std::filesystem::remove(dbFile);
}
}
}

} // namespace mostly_harmless::testing
Loading