-
Notifications
You must be signed in to change notification settings - Fork 21
Holdback Contract #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@salazarsebas could you check the github action , changes has been made which makes already existing path check fails on build . |
|
@salazarsebas looking at my checks error , it is the path check failing actual path apps/contracts/contract/** but now just apps/contracts/* |
|
Please make some changes so that the new workflow can be executed. For example, documentation that is not in Markdown format can be formatted by you. |
|
hi! thank you for your response , let me get on this . |
Just one tip for future contributions: always include a detailed description of the issue you're working on. This can help you receive more contributions in the future or even lead to new positions. It's also important to remember that open-source software (OSS) is public, which means anyone can see your work. So, I recommend learning more about atomic commits; you can check out this resource: https://dev.to/samuelfaure/how-atomic-git-commits-dramatically-increased-my-productivity-and-will-increase-yours-too-4a84. I've attached an image of your previous commits so you can see how others perceive them. For some of us, certain aspects of your commits can be a red flag.
|
|
sure i will get right into it . |
|
@Bran18 @salazarsebas kindly merge |
salazarsebas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM

closes #26
Holdback Contract (Soroban)
Overview
The Holdback Contract is a Soroban smart contract built with
soroban_sdkfor securely holding and releasing assets on the Stellar network.This contract enables: