Skip to content

Conversation

@blurbeast
Copy link
Contributor

@blurbeast blurbeast commented Aug 7, 2025

closes #26

Holdback Contract (Soroban)

Overview

The Holdback Contract is a Soroban smart contract built with soroban_sdk for securely holding and releasing assets on the Stellar network.

This contract enables:

  • Depositing assets into a secure escrow-like state.
  • Releasing funds to a recipient after meeting predefined conditions.
  • Refunding the sender if the release criteria are not met.
  • Event logging for full transparency on-chain.

@blurbeast
Copy link
Contributor Author

@salazarsebas could you check the github action , changes has been made which makes already existing path check fails on build .

@blurbeast
Copy link
Contributor Author

@salazarsebas looking at my checks error , it is the path check failing actual path apps/contracts/contract/** but now just apps/contracts/*

@salazarsebas
Copy link
Member

Please make some changes so that the new workflow can be executed. For example, documentation that is not in Markdown format can be formatted by you.

@blurbeast

@blurbeast
Copy link
Contributor Author

hi! thank you for your response , let me get on this .

@Bran18
Copy link
Contributor

Bran18 commented Aug 8, 2025

hi! thank you for your response , let me get on this .

Just one tip for future contributions: always include a detailed description of the issue you're working on. This can help you receive more contributions in the future or even lead to new positions. It's also important to remember that open-source software (OSS) is public, which means anyone can see your work. So, I recommend learning more about atomic commits; you can check out this resource: https://dev.to/samuelfaure/how-atomic-git-commits-dramatically-increased-my-productivity-and-will-increase-yours-too-4a84.

I've attached an image of your previous commits so you can see how others perceive them. For some of us, certain aspects of your commits can be a red flag.

Screenshot 2025-08-08 at 7 31 11 AM

@blurbeast
Copy link
Contributor Author

sure i will get right into it .

@blurbeast
Copy link
Contributor Author

@Bran18 @salazarsebas kindly merge

Copy link
Member

@salazarsebas salazarsebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@salazarsebas salazarsebas merged commit c954cbb into ScaffoldRust:main Aug 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement Holdback Guarantee Smart Contract and Tests

3 participants