Skip to content

Conversation

@ebrahimebrahim
Copy link
Contributor

The version was pinned to a pretty old one -- I think we should not have pinned it to begin with.

@arhowe00 for visibility

@ebrahimebrahim
Copy link
Contributor Author

ebrahimebrahim commented Dec 5, 2025

😮 ... since when is the extension name not supposed to start with "Slicer"? Do I really need to change the name?

@lassoan lassoan merged commit 0350c66 into Slicer:main Dec 7, 2025
2 of 3 checks passed
@lassoan
Copy link
Contributor

lassoan commented Dec 7, 2025

since when is the extension name not supposed to start with "Slicer"?

Yes, for obvious reasons, it would be bad if all extension names started with Slicer. It is useful to have the Slicer prefix in the extension repository name, but when we list extensions in the Extensions Manager, using the Slicer prefix is redundant and makes it a bit harder to find extensions.

Unfortunately, it took a few years for us to realize this, and so we have a number of extensions that use the Slicer prefix in the name. But it would be better to move away from this as much as possible.

The OpenLIFU Slicer extension can be called just that - OpenLIFU.

@ebrahimebrahim
Copy link
Contributor Author

It makes sense for sure; I was mentally equating the extn name with the repo name, but I see that the suggestion is to put Slicer in the repo name but not in the extension name. Thanks for merging! We just merged the name change as well

@lassoan
Copy link
Contributor

lassoan commented Dec 8, 2025

OK, thanks! I've updated the extension description json file accordingly. Note that on Slicer-5.10 the extension name is still SlicerOpenLIFU. To change that, you can create a new version (e.g., in v1.5.1) and then send a PR to the 5.10 branch of the ExtensionsIndex that changes the git tag and the json filename.

@ebrahimebrahim
Copy link
Contributor Author

ebrahimebrahim commented Dec 8, 2025

Ah, thanks for changing the json file name

To change that, you can create a new version (e.g., in v1.5.1) and then send a PR to the 5.10 branch of the ExtensionsIndex that changes the git tag and the json filename.

I am not sure I am following what you mean by create a new version. Is this what you mean: #2270

@lassoan
Copy link
Contributor

lassoan commented Dec 8, 2025

I meant that you need to create a new tag or branch that has the new extension name. Using the main branch as you did in #2270 is perfect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants