-
Notifications
You must be signed in to change notification settings - Fork 275
Pin the development version of ANTsPy for preview builds. #2265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR pins the development version of the ANTsPy extension for preview builds by updating the SCM revision from "main" to "UI-updates" branch.
- Changes the
scm_revisionfield in the SlicerANTsPy extension catalog entry to point to the "UI-updates" development branch
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
It would be more clear to follow existing convention of making the extension's branch name match the corresponding Slicer core branch name. Is there a specific reason that prevents following this convention? |
|
No not really. I want to make the development in UI-updates branch and do not want to touch main which is tied to the stable. But you are saying I should make a 5.10 branch from the current main and merge the UI-updated with main to follow the convention (so that I know what to do). |
|
Yes, we usually create a stable branch (e.g., |
|
I think it is correct now. There is a stable-5.10 branch for the stable and the UI-updates are merged with the main, and scm_revision is pointing to the main. Let me know if there anything I messed up. |
|
So I guess, there is nothing to be merged in this case I suppose. Preview versions will use the main, and the stable will "automatically" use the stable-5.10 branches? If you can confirm it will great, as i want to use this model with few of the SlicerMorph extensions. |
|
I am closing this. I have another PR #2267 that changes pins the stable versions to stable-5.10 branches. |
I need to keep the main for stable and pin the development to UI-updates branch for ANTsPy. The SlicerMorph change has already been incorporated.