Skip to content

Conversation

@muratmaga
Copy link
Contributor

I need to keep the main for stable and pin the development to UI-updates branch for ANTsPy. The SlicerMorph change has already been incorporated.

Copilot AI review requested due to automatic review settings December 6, 2025 01:27
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR pins the development version of the ANTsPy extension for preview builds by updating the SCM revision from "main" to "UI-updates" branch.

  • Changes the scm_revision field in the SlicerANTsPy extension catalog entry to point to the "UI-updates" development branch

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@lassoan
Copy link
Contributor

lassoan commented Dec 6, 2025

It would be more clear to follow existing convention of making the extension's branch name match the corresponding Slicer core branch name. Is there a specific reason that prevents following this convention?

@muratmaga
Copy link
Contributor Author

No not really. I want to make the development in UI-updates branch and do not want to touch main which is tied to the stable. But you are saying I should make a 5.10 branch from the current main and merge the UI-updated with main to follow the convention (so that I know what to do).

@lassoan
Copy link
Contributor

lassoan commented Dec 6, 2025

Yes, we usually create a stable branch (e.g., 5.10) in the extension repository whenever the extension's main branch starts to get commits that are experimental or not compatible with the Slicer stable release.

@muratmaga
Copy link
Contributor Author

I think it is correct now. There is a stable-5.10 branch for the stable and the UI-updates are merged with the main, and scm_revision is pointing to the main. Let me know if there anything I messed up.

@muratmaga
Copy link
Contributor Author

So I guess, there is nothing to be merged in this case I suppose. Preview versions will use the main, and the stable will "automatically" use the stable-5.10 branches? If you can confirm it will great, as i want to use this model with few of the SlicerMorph extensions.

@muratmaga
Copy link
Contributor Author

I am closing this. I have another PR #2267 that changes pins the stable versions to stable-5.10 branches.

@muratmaga muratmaga closed this Dec 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants