Skip to content

Conversation

@Slabity
Copy link
Collaborator

@Slabity Slabity commented Dec 16, 2025

Changing the versions for our dependencies to be explicit and allow stable versions to be used.

Bumping our version to 0.14.2 for publishing a crate to resolve #232 as well.

@Slabity Slabity requested a review from Drakulix December 16, 2025 21:48
Copy link
Contributor

@MarijnS95 MarijnS95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure we don't depend on any minimal patch versions; i.e. would this still build/run with -Zminimal-versions or -Zminimal-direct-versions?

EDIT: CI already checks this, and it's not happy with the removed minimal version spcifiers.

@Slabity
Copy link
Collaborator Author

Slabity commented Dec 16, 2025

EDIT: CI already checks this, and it's not happy with the removed minimal version spcifiers.

Odd... It built fine locally with cargo build --all --all-targets -Zminimal-versions

I'll take a look to see which dependency is throwing that error. It seems to be a procedural macro somewhere.

@MarijnS95
Copy link
Contributor

MarijnS95 commented Dec 16, 2025

-Zminimal-versions doesn't do anything if a Cargo.lock is already in place (cached from the previous run, rust-analyzer or similar).

You either need to remove it or pass that flag in conjunction with generate-lockfile.

Copy link
Member

@Drakulix Drakulix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bjorn3
Copy link
Contributor

bjorn3 commented Jan 4, 2026

Gentle ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Request to publish new release

4 participants