Skip to content

fix(iOS): New Architecture regression in download progress events #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
floydkim merged 1 commit into from
Dec 26, 2025
Merged

fix(iOS): New Architecture regression in download progress events #110

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 23 additions & 2 deletions ios/CodePush/CodePush.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ @implementation CodePush {
long long _latestExpectedContentLength;
long long _latestReceivedConentLength;
BOOL _didUpdateProgress;
NSTimeInterval _lastProgressEventTime;

BOOL _allowed;
BOOL _restartInProgress;
Expand Down Expand Up @@ -336,6 +337,18 @@ - (void)dispatchDownloadProgressEvent {
}];
}

- (void)dispatchThrottledDownloadProgressEventWithForce:(BOOL)force
{
static const NSTimeInterval interval = 0.05; // 50 ms throttle
NSTimeInterval now = CFAbsoluteTimeGetCurrent();
if (!force && _lastProgressEventTime > 0 && (now - _lastProgressEventTime) < interval) {
return;
}

_lastProgressEventTime = now;
[self dispatchDownloadProgressEvent];
}

/*
* This method ensures that the app was packaged with a JS bundle
* file, and if not, it throws the appropriate exception.
Expand Down Expand Up @@ -377,6 +390,7 @@ - (instancetype)init
_allowed = YES;
_restartInProgress = NO;
_restartQueue = [NSMutableArray arrayWithCapacity:1];
_lastProgressEventTime = 0;

self = [super init];
if (self) {
Expand Down Expand Up @@ -723,6 +737,7 @@ -(void)loadBundleOnTick:(NSTimer *)timer {
// progress events every frame if the progress is updated.
_didUpdateProgress = NO;
self.paused = NO;
_lastProgressEventTime = 0;
}

NSString * publicKey = [[CodePushConfig current] publicKey];
Expand All @@ -738,13 +753,19 @@ -(void)loadBundleOnTick:(NSTimer *)timer {
_latestExpectedContentLength = expectedContentLength;
_latestReceivedConentLength = receivedContentLength;
_didUpdateProgress = YES;
// Fabric/TurboModules don't hook RCTFrameUpdateObserver, so _pauseCallback
// stays nil there and we must emit progress events directly.
// On the legacy bridge _pauseCallback is set, and didUpdateFrame handles dispatch.
if (!_pauseCallback) {
[self dispatchThrottledDownloadProgressEventWithForce:NO];
}

// If the download is completed, stop observing frame
// updates and synchronously send the last event.
if (expectedContentLength == receivedContentLength) {
_didUpdateProgress = NO;
self.paused = YES;
[self dispatchDownloadProgressEvent];
[self dispatchThrottledDownloadProgressEventWithForce:YES];
}
}
// The download completed
Expand Down Expand Up @@ -1115,7 +1136,7 @@ - (void)didUpdateFrame:(RCTFrameUpdate *)update
return;
}

[self dispatchDownloadProgressEvent];
[self dispatchThrottledDownloadProgressEventWithForce:YES];
_didUpdateProgress = NO;
}

Expand Down