-
Notifications
You must be signed in to change notification settings - Fork 171
Various test fixes #1633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Various test fixes #1633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d93ae1a to
8b706ce
Compare
Contributor
Summary - All Code Coverage (ubuntu-latest)
|
219a049 to
44dc38f
Compare
6433cfc to
2b4f6d9
Compare
2b4f6d9 to
251ca8d
Compare
This reverts commit 251ca8d.
TimHess
previously approved these changes
Dec 11, 2025
Member
TimHess
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple nits, otherwise looks good to me
src/Management/test/Endpoint.Test/Actuators/RouteMappings/RazorPagesWebApplicationFactory.cs
Show resolved
Hide resolved
|
TimHess
approved these changes
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Backported changes from experimenting with running tests on MTPv2.
Make assertions ignore differences in line endings, originating from multi-line raw string literals. The code is compiled using the Windows newline separator, which differs from the newline separator used when executing on Ubuntu.
Referencexunit.v3.mtp-off, so we don't needDisableTestingPlatformServerCapability=falseanymore.Edit: Reverted back to reference
xunit.v3, becausexunit.v3.mtp-offbreaks running tests in WSL.A hanging test on all three frameworks took 9 minutes, leaving insufficient time to upload the dump in component builds (which time out after 15 minutes).
TestTfmsInParallelhas been fixed)skipFilterwith a boolean, which separates intent from implementationManagement.Endpoint.Testproject to speed up runsGuarded by an environment variable that is set in GHA, to not influence existing production behavior.