Skip to content

Conversation

@bart-vmware
Copy link
Member

@bart-vmware bart-vmware commented Dec 9, 2025

Backported changes from experimenting with running tests on MTPv2.

  • Fixes test failures when running in WSL2 on Ubuntu
    Make assertions ignore differences in line endings, originating from multi-line raw string literals. The code is compiled using the Windows newline separator, which differs from the newline separator used when executing on Ubuntu.
  • Explicitly target VSTest mode in xUnit
    Reference xunit.v3.mtp-off, so we don't need DisableTestingPlatformServerCapability=false anymore.
    Edit: Reverted back to reference xunit.v3, because xunit.v3.mtp-off breaks running tests in WSL.
  • Adds a workaround to prevent taking a dump on hanging/crashing test on macOS from timing out
  • Reduce test hang timeout from 3 to 1 minutes
    A hanging test on all three frameworks took 9 minutes, leaving insufficient time to upload the dump in component builds (which time out after 15 minutes).
  • Always write test output to a subdirectory, instead of the checkout root
  • Run tests for all frameworks in a single command (the bug ignoring TestTfmsInParallel has been fixed)
  • Replace skipFilter with a boolean, which separates intent from implementation
  • Run memory dump tests only for Management.Endpoint.Test project to speed up runs
  • Add diagnostics to investigate intermittent hostname lookup failures on macOS
    Guarded by an environment variable that is set in GHA, to not influence existing production behavior.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025

Summary - All Code Coverage (ubuntu-latest)

Line coverage Branch coverage

Assembly Line coverage Branch coverage
Steeltoe.Bootstrap.AutoConfiguration 97.4% 100%
Steeltoe.Common 84.3% 78.6%
Steeltoe.Common.Certificates 96.2% 85.5%
Steeltoe.Common.Hosting 84% 70%
Steeltoe.Common.Http 100% 85.2%
Steeltoe.Common.Logging 81.1% 56.2%
Steeltoe.Common.Net 64.5% 66.6%
Steeltoe.Configuration.Abstractions 98.5% 91.1%
Steeltoe.Configuration.CloudFoundry 99.1% 91.8%
Steeltoe.Configuration.ConfigServer 97.2% 91.6%
Steeltoe.Configuration.Encryption 97.6% 92.4%
Steeltoe.Configuration.Kubernetes.ServiceBindings 95.1% 89.3%
Steeltoe.Configuration.Placeholder 93.8% 84.7%
Steeltoe.Configuration.RandomValue 93.2% 90%
Steeltoe.Configuration.SpringBoot 98.3% 95%
Steeltoe.Connectors 93.9% 89.8%
Steeltoe.Connectors.EntityFrameworkCore 81.5% 75%
Steeltoe.Discovery.Configuration 92.3% 100%
Steeltoe.Discovery.Consul 97.6% 96.1%
Steeltoe.Discovery.Eureka 91.8% 85.2%
Steeltoe.Discovery.HttpClients 94.2% 95.4%
Steeltoe.Logging.Abstractions 99.4% 96.9%
Steeltoe.Logging.DynamicConsole 100% 95.4%
Steeltoe.Logging.DynamicSerilog 99.1% 95.4%
Steeltoe.Management.Abstractions 100% 100%
Steeltoe.Management.Endpoint 95.5% 89.1%
Steeltoe.Management.Prometheus 95.9% 91.6%
Steeltoe.Management.Tasks 100% ****
Steeltoe.Management.Tracing 100% 75%
Steeltoe.Security.Authentication.JwtBearer 100% 100%
Steeltoe.Security.Authentication.OpenIdConnect 73.8% 59%
Steeltoe.Security.Authorization.Certificate 96.3% 75%
Steeltoe.Security.DataProtection.Redis 100% ****

@bart-vmware bart-vmware force-pushed the test-fixes branch 2 times, most recently from 219a049 to 44dc38f Compare December 9, 2025 14:12
@bart-vmware bart-vmware force-pushed the test-fixes branch 2 times, most recently from 6433cfc to 2b4f6d9 Compare December 9, 2025 16:07
@bart-vmware bart-vmware marked this pull request as ready for review December 11, 2025 12:03
@bart-vmware bart-vmware requested a review from TimHess December 11, 2025 12:04
TimHess
TimHess previously approved these changes Dec 11, 2025
Copy link
Member

@TimHess TimHess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple nits, otherwise looks good to me

@sonarqubecloud
Copy link

@bart-vmware bart-vmware requested a review from TimHess December 12, 2025 14:03
@bart-vmware bart-vmware merged commit 939b77a into main Dec 15, 2025
25 checks passed
@bart-vmware bart-vmware deleted the test-fixes branch December 15, 2025 08:54
@bart-vmware bart-vmware added Type/infrastructure ReleaseLine/4.x Identified as a feature/fix for the 4.x release line labels Dec 15, 2025
@bart-vmware bart-vmware added this to the 4.1.0 milestone Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ReleaseLine/4.x Identified as a feature/fix for the 4.x release line Type/infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants