[FIX] #50 스터디룸 불필요 로직 제거 #51
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
📝작업 내용
기존코드
case "participant_left" -> {
Room room = roomRepository.findByTitle(roomName);
if (room != null) {
room.setParticipantCount(room.getParticipantCount() - 1);
roomRepository.save(room);
}
if (room != null && room.getParticipantCount() > 0) {
if (room != null && roomParticipantCount > 0) {
room.setParticipantCount(roomParticipantCount);
roomRepository.save(room);
System.out.println("Participant left. Current count: " + room.getParticipantCount());
log.info("Participant left now. Current count: {}", roomParticipantCount);
}
else if (room != null && room.getParticipantCount() == 0) {
else if (room != null && roomParticipantCount == 0) {
roomRepository.delete(room);
System.out.println("Room deleted: " + roomName);
log.info("Room deleted: {}", roomName);
}
}
불필요한 if 절을 제거하고 데이터베이스에서 방의 인원을 직접 수정하던 코드를
수정코드
int roomParticipantCount = event.getRoom().getNumParticipants();
웹훅을 수신하여 이벤트를 통해 받아온 방의 인원수를 데이터베이스에 담는 방식으로 수정하였습니다.