Loosen command restrictions #205
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for Param and function metadata respectively
and don't return to it when you leave. Also, make a context for shebang. Fixes SublimeText#198
michaelblyons
force-pushed
the
command-freeform
branch
from
be90881 to
e858587
Compare
michaelblyons
force-pushed
the
command-freeform
branch
from
a2cdb2a to
66c455e
Compare
Collaborator
Author
|
@msftrncs Hey Carl, do you have test assertions laying around from your previous work on the VSC/Atom tmLanguage for PowerShell? I could use some of the medium-to-gnarly test cases to see how I'm doing with Sublime Text's hard fork. |
Even if they are quoted.
michaelblyons
force-pushed
the
command-freeform
branch
from
66c455e to
7561b0e
Compare
michaelblyons
force-pushed
the
command-freeform
branch
2 times, most recently
from
d0d5498 to
9d0d77b
Compare
following regex operators
michaelblyons
force-pushed
the
command-freeform
branch
from
9d0d77b to
96cae36
Compare
Collaborator
Author
|
I'm merging into #202. See you folks there! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #202. Big potential for annoying behavior, but maybe the upside is worth it.
I'm hesitant to make quoted strings into commands, but that might be the right move. In theory, you're supposed to run
Invoke-Commandon a string to execute it, but the M$ docs also have a workflow example containing:And I ask: How do you know that the string is for executing? (Edit: Apparently workflows are invalid in Pwsh 6+)
In the meantime, I have decided that following the
&or.operators should qualify a string as a command.