COMP: Only build elxImpactMetricGTest.cxx when USE_ImpactMetric in ON #1389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aims to fix build errors that occur when USE_ImpactMetric is OFF, saying:
elastix\Components\Metrics\Impact\itkBSplineInterpolateVectorImageFunction.h(40,10): error C1083: Cannot open include file: 'torch/torch.h': No such file or directory
|
I tested the fix and it works for me With -DELASTIX_USE_GTEST=ON and USE_ImpactMetric=OFF, the build was indeed failing before, and it no longer does. For the tests, it might be good to wrap the Impact-related ones in an if(USE_ImpactMetric) so they are only included when Impact is enabled. |
N-Dekker
deleted the
Only-build-elxImpactMetricGTest-when-USE_ImpactMetric-is-ON
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims to fix build errors that occur when USE_ImpactMetric is OFF, saying:
@vboussot Please check if this fix works for you as well!