Skip to content

fix: use ingressClassName for sessions #4112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
leafty wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

fix: use ingressClassName for sessions #4112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e8dd36
fix: use ingressClassName for sessions
leafty Aug 5, 2025
6509398
update
leafty Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions helm-chart/renku/templates/notebooks/env-secret.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ stringData:
NB_SESSIONS__OIDC__TOKEN_URL: {{ .Values.notebooks.oidc.tokenUrl | default (printf "https://%s/auth/realms/Renku/protocol/openid-connect/token" .Values.global.renku.domain) }}
NB_SESSIONS__OIDC__ISSUER_URL: {{ template "renku.keycloakIssuerUrl" . }}
NB_SESSIONS__OIDC__ALLOW_UNVERIFIED_EMAIL: {{ .Values.notebooks.oidc.allowUnverifiedEmail | quote }}
NB_SESSIONS__INGRESS__CLASSNAME: {{ .Values.notebooks.sessionIngress.className | default "" }}
NB_SESSIONS__INGRESS__HOST: {{ .Values.notebooks.sessionIngress.host | default .Values.global.renku.domain }}
NB_SESSIONS__INGRESS__TLS_SECRET: {{ .Values.notebooks.sessionIngress.tlsSecret | default (printf "%s-ch-tls" .Release.Name) }}
NB_SESSIONS__INGRESS__ANNOTATIONS: |
Expand Down
7 changes: 4 additions & 3 deletions helm-chart/renku/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,10 +210,10 @@ global:
ingress:
## Enables the creation of an ingress
enabled: false
className: "" # nginx
## The ingress class, e.g. "nginx"
className: ""
## Annotations for the created ingress
annotations:
## The ingress class
cert-manager.io/cluster-issuer: letsencrypt-production # Use null as value if not using cert-manager to remove this entry
nginx.ingress.kubernetes.io/proxy-body-size: "0" # Adjust to a reasonable value for production to avoid DOS attacks.
nginx.ingress.kubernetes.io/proxy-request-buffering: "off" # Needed if GitLab is behind this ingress
Expand Down Expand Up @@ -889,10 +889,11 @@ notebooks:
authUrl:
allowUnverifiedEmail: false
sessionIngress:
## The ingress class, e.g. "nginx"
className: ""
host:
tlsSecret:
annotations:
kubernetes.io/ingress.class: nginx
nginx.ingress.kubernetes.io/proxy-body-size: "0"
nginx.ingress.kubernetes.io/proxy-buffer-size: 8k
nginx.ingress.kubernetes.io/proxy-request-buffering: "off"
Expand Down
3 changes: 1 addition & 2 deletions minimal-deployment/minimal-deployment-values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,7 @@ notebooks:
values:
- user
sessionIngress:
annotations:
kubernetes.io/ingress.class: webapprouting.kubernetes.azure.com
className: webapprouting.kubernetes.azure.com
sessionTolerations:
- effect: NoSchedule
key: renku.io/dedicated
Expand Down