Skip to content

Conversation

@sgaist
Copy link
Collaborator

@sgaist sgaist commented Dec 11, 2025

Describe your changes

This PR removes the enableV1Services flag as well as all the resources behind it from the helm chart.

Issue(s) ticket number(s) and link(s)

Fixes #4280

/deploy

@sgaist sgaist requested review from a team as code owners December 11, 2025 15:08
@rokroskar
Copy link
Member

I guess this replaces #4279 ?

@sgaist
Copy link
Collaborator Author

sgaist commented Dec 12, 2025

Replaces or complements
I discussed with @leafty and she told me I should move forward with my PR.

@leafty
Copy link
Member

leafty commented Dec 12, 2025

yes, no problem, close #4279 if we already have a superset of the changes here.

Copy link
Member

@olevski olevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mentioned a few extra things that can be removed. If you want you can also do them in a followup PR.

test:
enabled: false
## Configuration for renku-graph services
graph:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more things can be removed:

  • .global.core
  • .global.graph
  • .dlf-chart
  • .jena

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are even a few more sections that can be removed. But these "other sections" I did not mention above, because they all need code changes in the data service before we can remove them from here.

@olevski
Copy link
Member

olevski commented Dec 15, 2025

Oh and please add /deploy to this. To make sure we get a ci deployment and the helm chart works.

@sgaist sgaist force-pushed the refactor/remove-obsolete-items branch from c1f59bd to 479fadd Compare December 16, 2025 09:30
@RenkuBot
Copy link
Collaborator

You can access the deployment of this PR at https://ci-renku-4281.dev.renku.ch

sgaist and others added 4 commits December 16, 2025 10:38
* feat: upgrade renku-ui to 4.14.0

* feat: upgrade data services to 0.64.0

* chore: add docs for mounting openbis data
Explicitly hard code it and webhooks as
to-be-removed as they are v1 only features
mohammad-alisafaee and others added 2 commits December 18, 2025 12:10
* test(cypress): tests for group (#4254)
* test(cypress): more data connector tests (#4256)
* test(cypress): tests for code repositories (#4270)
* test(cypress): tests for sessions (#4271)
* test(cypress): tests for slow running sessions (#4277)
* chore: update GitHub actions to remove legacy tests and add support for slow tests

---------

Co-authored-by: Lorenzo Cavazzi <43481553+lorenzo-cavazzi@users.noreply.github.com>
@olevski olevski changed the base branch from release-2.12.0 to release-2.13.0 December 22, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants