-
Notifications
You must be signed in to change notification settings - Fork 36
refactor: remove V1 resources #4281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-2.13.0
Are you sure you want to change the base?
Conversation
|
I guess this replaces #4279 ? |
|
Replaces or complements |
|
yes, no problem, close #4279 if we already have a superset of the changes here. |
olevski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mentioned a few extra things that can be removed. If you want you can also do them in a followup PR.
| test: | ||
| enabled: false | ||
| ## Configuration for renku-graph services | ||
| graph: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more things can be removed:
- .global.core
- .global.graph
- .dlf-chart
- .jena
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are even a few more sections that can be removed. But these "other sections" I did not mention above, because they all need code changes in the data service before we can remove them from here.
|
Oh and please add |
They are obsolete and unused components
This folder can be created when testing locally.
Co-authored-by: Tasko Olevski <tasko.olevski@sdsc.ethz.ch>
c1f59bd to
479fadd
Compare
|
You can access the deployment of this PR at https://ci-renku-4281.dev.renku.ch |
* feat: upgrade renku-ui to 4.14.0 * feat: upgrade data services to 0.64.0 * chore: add docs for mounting openbis data
Explicitly hard code it and webhooks as to-be-removed as they are v1 only features
* test(cypress): tests for group (#4254) * test(cypress): more data connector tests (#4256) * test(cypress): tests for code repositories (#4270) * test(cypress): tests for sessions (#4271) * test(cypress): tests for slow running sessions (#4277) * chore: update GitHub actions to remove legacy tests and add support for slow tests --------- Co-authored-by: Lorenzo Cavazzi <43481553+lorenzo-cavazzi@users.noreply.github.com>
c142fa8 to
3e27337
Compare
b12f8ad to
a1a92dc
Compare
Describe your changes
This PR removes the
enableV1Servicesflag as well as all the resources behind it from the helm chart.Issue(s) ticket number(s) and link(s)
Fixes #4280
/deploy