Skip to content

[Admin] Render button for order refund only if refund is possible #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GSadee wants to merge 3 commits into
base: 2.0
Choose a base branch
from
Open

[Admin] Render button for order refund only if refund is possible #477

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ab809a3
[Admin] Render button for order refund only if refund is possible
GSadee Sep 29, 2025
0c19460
[Behat][Admin] Adjust scenario for rendering refund button
GSadee Sep 29, 2025
4d98c44
Add /var directory to .gitignore file
GSadee Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

/tests/TestApplication/.env.local
/tests/TestApplication/.env.*.local
/var/

phpspec.yml

Expand Down
2 changes: 1 addition & 1 deletion features/refunding_single_order_unit.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ Feature: Refunding a single order unit
@ui
Scenario: Not being able to refund unit from an order that is unpaid
When I am viewing the summary of the order "#00000022"
Then I should see disabled refunds button
Then I should not see refunds button

@application
Scenario: Not being able to refund unit from an order that is unpaid
Expand Down
13 changes: 8 additions & 5 deletions templates/admin/order/content/header/title_block/actions/refunds.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
{% set order = hookable_metadata.context.resource %}
{% set path = path('sylius_refund_order_refunds_list', {'orderNumber': order.number,}) %}

<a class="dropdown-item {% if not can_refund_order(order.number) %}disabled{% endif %}" href="{{ path }}" {{ sylius_test_html_attribute('refunds') }}>
{{ ux_icon('tabler:repeat', {'class': 'icon dropdown-item-icon'}) }}
{{ 'sylius_refund.ui.refunds'|trans }}
</a>
{% if can_refund_order(order.number) %}
{% set path = path('sylius_refund_order_refunds_list', {'orderNumber': order.number,}) %}

<a class="dropdown-item" href="{{ path }}" {{ sylius_test_html_attribute('refunds') }}>
{{ ux_icon('tabler:repeat', {'class': 'icon dropdown-item-icon'}) }}
{{ 'sylius_refund.ui.refunds'|trans }}
</a>
{% endif %}
4 changes: 1 addition & 3 deletions tests/Behat/Context/Ui/ManagingOrdersContext.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,7 @@ public function shouldBeNotifiedThatTheOrderShouldBePaid(): void
);
}

/**
* @Then I should not see refunds button
*/
#[Then('I should not see refunds button')]
public function iShouldNotSeeRefundsButton(): void
{
Assert::false($this->showPage->hasRefundsButton());
Expand Down
2 changes: 1 addition & 1 deletion tests/Behat/Page/Admin/Order/ShowPage.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ public function hasDownloadCreditMemoButton(int $index): bool

public function hasRefundsButton(): bool
{
return $this->getDocument()->hasButton('Refunds');
return $this->getDocument()->has('css', '[data-test-refunds]');
}

public function hasDisabledRefundsButton(): bool
Expand Down
Loading