-
Notifications
You must be signed in to change notification settings - Fork 27
MX2 Fixes #895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MX2 Fixes #895
Conversation
🚀 Preview available 🚀https://55f9e0cf.tbil.pages.dev
|
🚀 Preview available 🚀https://7d809317.tbil.pages.dev
|
|
Can you supply some context here? What are we fixing and why? |
| "invertible": False, | ||
| "label": labels[1], | ||
| "vector_eq": TBIL.VectorEquation(m), | ||
| "ordinal": ordinal_string, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will fix the non-invertible question so it doesn't ask for a [blank] column of the inverse.
|
Sorry, context is now added! Meant to post it earlier but got distracted by a butterfly wafting in the wind (or something). |
.vscode/settings.json
Outdated
| { | ||
| "githubPullRequests.ignoredPullRequestBranches": [ | ||
| "main" | ||
| ] | ||
| } No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should .vscode/* be added to the gitignore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No -- if we want this to be a setting, it should be in .devcontainer. I'll fix.
|
Looks fine, pending question about the settings file above. |
🚀 Preview available 🚀https://87af0a54.tbil.pages.dev
|
|
I think this is done; we need an approval to merge. |
🚀 Preview available 🚀https://a9d0d601.tbil.pages.dev
|
Fix MX2 so the non-invertible task doesn't have an incomplete template.
Also shuffles the order to prompt the student to compute a column by hand first, and then verify with technology.