Skip to content

Conversation

@yagee-de
Copy link
Member

copy legacy code from MyCoRe/MIR 2025.06.x branch here that is deleted now

This pull request introduces several enhancements and fixes across the codebase, focusing on improving access key event handling, updating dependency and plugin configurations, and refining object retrieval and event processing logic. The most notable change is the addition of a new event handler for managing access keys, along with several dependency and code updates to support and streamline related functionality.

Access Key Management Enhancements:

  • Added a new class MCRAccessKeyEventHandler to handle creation, update, and deletion events for objects and derivates, ensuring proper import and cleanup of access keys associated with MyCoRe entities.

Build and Dependency Updates:

  • Updated the MyCoRe version in pom.xml from 2025.06.1-SNAPSHOT to 2025.12.0-SNAPSHOT and added the mycore-junit4 test dependency. [1] [2]
  • Introduced configuration for the maven-compiler-plugin to show deprecation and warning messages during test compilation, with a note to migrate from JUnit4 to JUnit5 in the future.

Object Retrieval and Event Handling Improvements:

  • Changed object retrieval in RepairCommands.setMainFile() to use MCRExpandedObject instead of MCRObject, aligning with updated data model usage.
  • In MigrationCommands.repairDerivate, removed the logic that added enriched derivate links to metadata, simplifying the repair process.

General Code Quality and Bug Fixes:

  • Updated email retrieval in Attendee to use getEMail() instead of the deprecated getEMailAddress().
  • Fixed author name encoding in DerivateServletFilter and simplified redirect logic by removing unnecessary checks for empty URLs. [1] [2]
  • Updated object ID retrieval in both DerivateServletFilter and VideoSourceResource to remove the use of timeouts, using the simpler method signature. [1] [2]

Dependency and Import Cleanups:

  • Added missing import for MCRExpandedObject in RepairCommands.java.

These changes collectively improve the maintainability, reliability, and clarity of the codebase, especially around access key management and build processes.

copy legacy code from MyCoRe/MIR 2025.06.x branch here that is deleted now
@yagee-de yagee-de force-pushed the issues/DBT-397-update-to-mir-2025-12-x branch from 88801d6 to 4403fa3 Compare November 21, 2025 10:25
@yagee-de yagee-de merged commit ef93180 into main Nov 21, 2025
7 checks passed
@yagee-de yagee-de deleted the issues/DBT-397-update-to-mir-2025-12-x branch November 21, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants