Skip to content

feat: leetcode zigzag solution #897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Panquesito7 merged 28 commits into from
Dec 9, 2021
Merged

feat: leetcode zigzag solution #897

Panquesito7 merged 28 commits into from
Dec 9, 2021

Conversation

@straight-into-the-wall
Copy link
Contributor

@straight-into-the-wall straight-into-the-wall commented Oct 22, 2021 •
edited by gitpod-io bot
Loading

Description of Change

A solution for the ZigZag conversion problem.

References

Hacktoberfest issue

ZigZag Conversion problem on leetcode

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes: Solution to the 6-ZigZag conversion problem was missing. Here is (decent) one.

ZigZagConversion-SubmissionDetail-LeetCode.pdf

@straight-into-the-wall straight-into-the-wall marked this pull request as ready for review October 22, 2021 14:29
@straight-into-the-wall
Copy link
Contributor Author

straight-into-the-wall commented Oct 22, 2021

Hey @Panquesito7 @kvedala,

On my fork's Github Actions I got this error from Awesome CI Workflow Code formatter; even if I separated the two files into two different commits.

2 files are not in one and only one directory:
leetcode/src/1.c
leetcode/src/6.c

Error: Process completed with exit code 2.

Any idea how I could fix it?

Thanx

awesome_error

@straight-into-the-wall straight-into-the-wall mentioned this pull request Oct 22, 2021
Closed
Panquesito7
Panquesito7 requested changes Oct 22, 2021
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! 😄👍

@Panquesito7 Panquesito7 added Autochecks are failing Failing CI Auto-checks Changes requested enhancement New feature or request labels Oct 22, 2021
Panquesito7
Panquesito7 requested changes Oct 24, 2021
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix clang-tidy warnings. Let us know if you need any help here or in our Discord server. 😃

Panquesito7
Panquesito7 requested changes Oct 24, 2021
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still failing here.

@straight-into-the-wall
Copy link
Contributor Author

straight-into-the-wall commented Oct 24, 2021

I've done clang-tidy --fix --quiet -p build leetcode/src/6.c -- on my side without any warning. The Awesome CI error message is quite cryptic 1 files are not in one and only one directory. I've checked and didn't find any other file named 6.c in the whole repo. ... waiting for help on #898 and Discord server.

@straight-into-the-wall
Copy link
Contributor Author

straight-into-the-wall commented Oct 25, 2021

solved by PR #900 ?

@Panquesito7 Panquesito7 mentioned this pull request Oct 31, 2021
Merged
@Panquesito7
Copy link
Member

Panquesito7 commented Oct 31, 2021

Still failing. 👀

@straight-into-the-wall
Copy link
Contributor Author

straight-into-the-wall commented Oct 31, 2021 •
edited
Loading

Somehow this PR was again tested with the buggy version of awesome_workflow.yml:

image

You can see in the details of the failing check.

image

and then in failing workflow file:

image

Master branch now seems to have the right .github/workflows/awesome_workflow.yml

image

... Maybe relaunch the tests ?

@Panquesito7 Panquesito7 removed the Autochecks are failing Failing CI Auto-checks label Oct 31, 2021
Panquesito7
Panquesito7 reviewed Oct 31, 2021
View reviewed changes
straight-into-the-wall and others added 2 commits November 4, 2021 21:40
@straight-into-the-wall @Panquesito7
Update leetcode/src/6.c
def0eb6 
Co-authored-by: David Leal <halfpacho@gmail.com>
@straight-into-the-wall @Panquesito7
Update leetcode/src/6.c
143a741 
Co-authored-by: David Leal <halfpacho@gmail.com>
@Panquesito7
Copy link
Member

Panquesito7 commented Nov 5, 2021

I've seen the tests are failing in other PRs with the same issue you had in this PR. Would you like to investigate? Thanks. 🙂

@straight-into-the-wall
Copy link
Contributor Author

straight-into-the-wall commented Nov 8, 2021

I've seen the tests are failing in other PRs with the same issue you had in this PR. Would you like to investigate? Thanks. slightly_smiling_face

I checked some of the waiting PR but any of them has the same issue that this one. Could you link some references?

@Panquesito7
Copy link
Member

Panquesito7 commented Nov 8, 2021 •
edited
Loading

I've seen the tests are failing in other PRs with the same issue you had in this PR. Would you like to investigate? Thanks. 🙂

I checked some of the waiting PR but any of them has the same issue that this one. Could you link some references?

#914

Panquesito7
Panquesito7 reviewed Nov 10, 2021
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A question: there's no main function? 🤔

@straight-into-the-wall
Copy link
Contributor Author

straight-into-the-wall commented Nov 21, 2021 •
edited
Loading

A question: there's no main function?

@Panquesito7

added main function.

Panquesito7
Panquesito7 reviewed Nov 21, 2021
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! 😄

Panquesito7
Panquesito7 approved these changes Nov 21, 2021
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Thanks for your contribution! 😄👍

@Panquesito7 Panquesito7 added approved Approved; waiting for merge and removed Changes requested labels Nov 21, 2021
@straight-into-the-wall
Copy link
Contributor Author

straight-into-the-wall commented Dec 9, 2021

@ayaankhan98 @mishraabhinn @Panquesito7 ... ping? 😉

@Panquesito7 Panquesito7 merged commit 37534f4 into TheAlgorithms:master Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Panquesito7 Panquesito7 Panquesito7 approved these changes

@ayaankhan98 ayaankhan98 Awaiting requested review from ayaankhan98

@mishraabhinn mishraabhinn Awaiting requested review from mishraabhinn

+1 more reviewer

@aminoxix aminoxix aminoxix approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Approved; waiting for merge enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@straight-into-the-wall @Panquesito7 @aminoxix