Skip to content

Mw/fix truthy classes list #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michaelwood merged 2 commits into from
May 29, 2025
Merged

Mw/fix truthy classes list #158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f318c69
lib360dataquality: Make sure we don't run all test types if specified
michaelwood May 27, 2025
ec33cb3
tools: cove_checks: Update the common_checks_360 arguments for new dqt
michaelwood May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib360dataquality/cove/threesixtygiving.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,7 @@ def common_checks_360(
upload_dir: directory file exists in if non-json file_type, also used to store validation errors json
json_data: { grants: [,,] }
schema_obj: See lib360dataQuality/cove/schema.py for Schema360
tests: array of test functions to run. Defaults to all available.
test_classes: array of test functions to run. Defaults to all available if None.
"""

schema_name = schema_obj.pkg_schema_name
Expand All @@ -378,7 +378,7 @@ def common_checks_360(
cell_source_map = common_checks["cell_source_map"]

# If no particular test classes are supplied then run all defined here
if not test_classes:
if test_classes is None:
test_classes = [TestType.QUALITY_TEST_CLASS, TestType.USEFULNESS_TEST_CLASS]

if context["file_type"] == "xlsx":
Expand Down
3 changes: 2 additions & 1 deletion tools/cove_checks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,8 @@ def main():
file_path,
file_type,
lib_cove_config,
schema.schema_url,
schema.schema_file,
schema.pkg_schema_file
)
)
with open(context["converted_path"], "r") as fp_data:
Expand Down