Monitoring non-GBP currencies #315
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a bug in rewrite_quality_data where the function would fail when arguments threads=0 and publishers_only=False were set, due to not exporting the results of processing sourcefile quality data / stats.
This commit adds an option to fake_grant() to choose a non-GBP currency when creating a fake grant. Also SourceFile aggregate data is now generated from grants instead of being directly mocked.
This commit enables tracking sum totals for grants in select currencies other than GBP (at the moment EUR and USD).
mrshll1001
approved these changes
Dec 12, 2025
mrshll1001
left a comment
mrshll1001
left a comment
There was a problem hiding this comment.
I believe this is safe to merge, so please go ahead :-)
A thought: Obviously the job at hand is to specifically handle USD and EUR grants in addition to GBP – but are we not just creating tech debt by hard-coding this in various places? There are a few places where there are hard-coded mentions of them e.g. in datastore/monitoring/metrics.py L167; could we be gathering totals for currencies and then adding them to the dict? How much work would it be to handle arbitrary currencies?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: