(Headline) Correct footer layout bug for sites with long copyrights #398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct a layout bug for sites with long copyright notices.
cathysarisky
changed the title
markstos
approved these changes
Apr 19, 2025
Contributor
markstos
left a comment
markstos
left a comment
There was a problem hiding this comment.
Peer-reviewing as a Headline theme user and confirming this is a good fix. Before, the copyright could overflow. Now it wraps.
Before
After
Contributor
|
I also searched all the other themes to see if they also mention |
Member
|
The underlying cause is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the Headline theme footer, where the copyright element does not wrap. It's a problem particularly on mobile for sites with long titles or long custom text in the @custom.footer_text variable. nowrap is being inherited from gh-foot, so we need to explicitly set wrap for the copyright element.