[#53] Review and Optimize #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates submodule references and optimizes the build process by adding a build step for the simulith component. The changes appear to be focused on container and build process improvements as indicated by the title.
- Updates multiple git submodule commit references across components
- Adds explicit build command for simulith component in the Makefile
- Addresses issues #53 and #55 related to container and build optimization
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| simulith | Updates submodule commit reference |
| fsw | Updates submodule commit reference |
| comp/radio | Updates submodule commit reference |
| comp/eps | Updates submodule commit reference |
| comp/demo | Updates submodule commit reference |
| comp/adcs | Updates submodule commit reference |
| Makefile | Adds explicit build command for simulith component |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
jlucas9
added a commit
that referenced
this pull request
Sep 25, 2025
* [#24] Component Mold and EPS (#50) * [#24] Created tryspace-comp-mold.py; * [#26] Initial comp/eps from mold; * [#26] Overhaul the EPS to use I2C; * [#26] Updated cli to use orchestrator and proved with EPS; * [#26] Removed standalone sims in favor of libraries for tryspace-director; * [#26] Resolved error with eps.xtce; * [#26] Flattened GSW command structure and fixed conversions; * [#26] Updates to submodules after PR review; * [#27] Radio Component (#52) * [#27] Initial mold for radio from demo component; * [#27] Radio NOOP and HK working with CLI; * [#27] Added radio app to FSW; * [#27] Radio downlink functional; * [#27] Wrapped debug prints in *_CFG_DEBUG statements; * [#27] Updated radio unit tests; * [#27] Added log_mode to default active.yaml; * [#27] Updates after PR reviews; * [#28] Updates to use cryptolib with radio; (#61) * [#28] Updates to use cryptolib with radio; * [#28] Updates for unit tests; * [#28] Update to latest tryspace-lab:0.0.1; * [#28] Update after PR review; * [#35] 42 GUI (#62) * [#35] Added 42 truth telemetry; * [#35] Added demo display and procedure; * [#35] Resolved issue with nesting components; * [#35] Submodule updates after PR review; * [#20] CF, DS, LC, SC (#63) * [#20] Try to setup CFDP; * [#20] Updates to CFDP: * [#20] CFDP upload EIDs set; * [#20] Class 2 CFDP transactions (manual downlink); * [#20] Updates after submodule merges; * [#25] ADCS Component (#65) * [#25] Added ./comp/adcs submodule * [#25] Initial ADCS; * [#25] ADCS updates to xtce and unit tests; * [#25] Submodule updates after PR review; * [#29] Design Reference Mission (#66) * [#29] Initial updates from DRM effort; * [#29] Resolved EPS tlm packet offset issue; * [#29] Updated architecture and DRM; * [#29] Updated unit-tests after changes; * [#29] Submodule updates after merges; * [#51] Strict build flags (#67) * [#51] Modifications after CompFlags.cmake improvements; * [#51] Separate flags for unit tests; * [#51] CLI updates for strict flags; * [#54] CLI CI; * [#54] build-cli updated to avoid docker calls; * [#51] Submodule updates after merges; * [#58] Added backdoor simulator interface; (#68) * [#58] Added backdoor simulator interface; * [#58] Updates after submodule merges; * [#53] Review and Optimize (#69) * [#53] CMake update to use libsimulith.so; * [#55] Additional tests in simulith; * [#53] Submodule update after merges; * [#30] Multiple Configurations (#70) * [#30] Orchestrator support for spacecraft; * [#30] Moved tryspace_defs from fsw to cfg; * [#30] Support spacecraft builds; * [#30] Support spacecraft fsw cfgs; * [#30] Mission and spacecraft build directories; * [#30] Mission and spacecraft in runtime name; * [#30] Address missing active.yaml configuration defaults; * [#30] Address missing parameters for FSW CI; * [#30] Look for libsimulith.so in multiple places for runtime; * [#30] Search for perfids.h in the right location; * [#30] Spacecraft FSW cfg now tryspace_defs; * [#30] Rename the mission configuration to the default; * [#30] Submodule updates after merges; * [#71] Updates to submodules after merges; (#72)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Containers and build process.
Submodule PRs:
Closes #53.
Closes #55.