[tryspaceorg/tryspace-lab#14] CI #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p make / cmake, and add CI;
jlucas9
changed the title
jlucas9
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR sets up continuous integration (CI) for the TrySpace Simulith project by adding GitHub Actions workflows and updating Docker image references to use the public registry.
- Added GitHub Actions CI workflow with build and test jobs
- Updated Docker image references from local
tryspace-lab:latestto publictryspaceorg/tryspace-lab:latest - Refactored Makefile build targets for better modularity and CI compatibility
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/ci.yml | New CI workflow with build-sim and build-test jobs using the public Docker image |
| test/Dockerfile.server | Updated base image to use public registry |
| test/Dockerfile.director | Updated base image to use public registry |
| Makefile | Refactored build targets, updated image references, and improved CI compatibility |
| CMakeLists.txt | Enhanced CMake configuration with better target organization and modern practices |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.