remove bugged ISA checks from lib/src/sailsim-riscv.cpp
#1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to get MapacheSPIM running on my machine after Dr. Sherwood showed me it at CCS Computing Collab Hours a couple weeks ago, and ran into an issue with building
lib. As far as I can tell, the ISA checks for a loaded ELF were using nonexistant functions and classes, and the correct behavior is to lean on the try-catch to ensure we are reading a RISC-V ELF file. I could be missing something, but this is what got it building on my machine :)