nfip claims testing / documentation #52
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added documentation and built out NFIP claims function. Two questions for review: I believe the net... columns (net_building_payment_amount, net_contents_payment_amount) are the best values to use for amount paid to the person who submitted the claim but there are also amount_paid.. columns. The net_.. columns are consistently lower (with only a few exceptions) than amount_paid so my interpretation is they take into account the total of cashed / uncashed checks but wanted to double check if you interpret this the same way: https://www.fema.gov/openfema-data-page/fima-nfip-redacted-claims-v2.
I also saved a version of the full cleaned dataset to box since this one also takes a moment to run on its own. I tried to incorporate this into the function (to read from the cleaned dataset if it exists) but think I'm having some trouble getting the if statements layered in correctly. I added my attempt in the comments at the bottom.
Thanks for the review and feel free to let me know if you have any questions about the code or the above questions!