Skip to content

Conversation

@brchen3
Copy link
Collaborator

@brchen3 brchen3 commented Oct 20, 2025

updating business patterns script to include the selected naics codes and year and ignore some of the higher codes that do not have any associated data.

updating the LODES script to properly join data based on whether it is "wac", "rac", or "od" data being requested

@brchen3 brchen3 requested a review from wcurrangroome October 20, 2025 16:16
Copy link
Collaborator

@wcurrangroome wcurrangroome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For both datasets:

  • Can you add a @details chunk to the Roxygen documentation clarifying what the data represent, what they can be used for, their limitations, how they differ from LEHD/LODES, etc.?
  • Can you add details about the fields that are included in the returned dataframe as part of the roxygen documentation? Refer to get_public_assistance.R for an example: https://github.com/UI-Research/climateapi/blob/main/R/get_public_assistance.R
  • Can you build out a corresponding test file that encompasses testable assertions about how each function should behave? I creates these files (no contents yet) in /tests/testthat. Check out https://r-pkgs.org/testing-basics.html for an introduction to the approach. Some good things to test for include: valid responses for valid combinations of parameters; clear errors for invalid parameters; missingness levels for returned data; the absence of any values that are infeasible (e.g., negative counts, percentages greater than 100%, etc.).

@wcurrangroome
Copy link
Collaborator

Also, the base get_business_pattern() function was working but is now throwing an error... I'm wondering if it's an issue with the Census API (hopefully short-lived)? Else I might have accidentally altered something in the code (sorry if so).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants