Ci #19
Merged
Ci #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me unneeded services that may run.
Fix AWS Region error on deployment configuration
Fix AWS Region issue on deployment configuration (dev)
…that use os.getenv function
…ined at the beginning of the CF stack function.
… fixes the unresolved tokens error
This was
linked to
issues
Jul 2, 2025
cjcocokrisp
reviewed
Jul 2, 2025
| APP_NAME = ssm.StringParameter.value_from_lookup( | ||
| self, | ||
| parameter_name="/immersion/app_name" | ||
| ) |
| DISCORD_TOKEN = ssm.StringParameter.value_from_lookup( | ||
| self, | ||
| parameter_name="/immersion/discord-token-secure" | ||
| ) |
| SSM_PARAMETER_NAME_API = ssm.StringParameter.value_from_lookup( | ||
| self, | ||
| parameter_name="engage_api_key_test" | ||
| ) |
| runtime=Runtime.PYTHON_3_13, | ||
| entry='src/data_filters/onboarding', | ||
| f"{APP_NAME}ClubInformationLambda", | ||
| runtime=Runtime.PYTHON_3_10, |
Contributor
There was a problem hiding this comment.
Why did we change versions?
Collaborator
Author
There was a problem hiding this comment.
For some reason it's invalid
| SSM_PARAMETER_NAME_API = ssm.StringParameter.value_from_lookup( | ||
| self, | ||
| parameter_name="engage_api_key_test" | ||
| ) |
Contributor
There was a problem hiding this comment.
Same indentation issues as the other file
cjcocokrisp
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#14 #16 Building CDK stack succeeds!!