Test create admin user #2266
Merged
Test create admin user #2266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…qiange-fixcreateadmin
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds test coverage for the admin user creation logic and removes a guard that was preventing proper testing of this functionality. The tests verify that the default admin user is created only when necessary.
Key Changes
- Removed the
$FIRST_TIME_RUNguard in_init_user_admin()to allow admin user creation checks on every install call - Added
test_admin_no_need()to verify that the default 'admin' user is not created when another admin already exists - Added
test_default_admin()to verify that the default 'admin' user is created when no admin users exist
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| lib/Ravada.pm | Removes the FIRST_TIME_RUN guard from _init_user_admin() to enable the admin creation logic to run on every _install() call, which is necessary for testing multiple scenarios |
| t/user/50_admin.t | Adds two new test functions to verify admin user creation behavior: one testing that admin is not created when unnecessary, and one testing that admin is created when needed |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| $user = Ravada::Auth::SQL->new(name => 'admin'); | ||
| ok(!$user->id) or exit; | ||
| } | ||
|
|
There was a problem hiding this comment.
[nitpick] Missing description for the test function. Consider adding a comment to document what this test verifies:
# Test that default admin user is created when no admin exists
sub test_default_admin {
Suggested change
| # Test that default admin user is created when no admin exists |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests create user when necessary and makes sure it is not created when another admin user is already there.