Skip to content

Conversation

@alegs-a
Copy link
Collaborator

@alegs-a alegs-a commented Jul 25, 2025

A domain computing the reduced product of the interval and tnum analyses. For a whole lot of words, go read winter_research_reduced_product.pdf

@alegs-a alegs-a marked this pull request as ready for review July 25, 2025 05:20
@alegs-a alegs-a marked this pull request as draft July 25, 2025 06:48
@alegs-a
Copy link
Collaborator Author

alegs-a commented Jul 25, 2025

This can't be merged yet because the known bits analysis doesn't play nicely. Specifically, getting variables out of known bits' map (unreduced._2(v)) on line 88 of Domains.scala will cause a crash if that variable doesn't exist. This is the reason for the test which currently fails. If the known bits analysis used a LatticeMap then we could .getOrElse() to go to bottom in this case, or there are probably other ways of gracefully handling this that I'm not aware of.

@agle
Copy link
Contributor

agle commented Aug 25, 2025

My plan with this is to refactor this on top of a single-value domain abstraction to avoid the complexity of computing the reduced product of two different map types. This means waiting for a slightly substantial refactor of the known bits analysis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants