Skip to content

Conversation

@Jesseable
Copy link
Collaborator

No description provided.

Jesse Graf added 30 commits May 8, 2025 09:20
…ile and updates in the api-information.md file
…IR between transform passes on the localhost webpage
… and creates working IR-IR display with react and typescript
…erface-thesis-proj

# Conflicts:
#	build.sc
#	docs/src/development/api-information.md
#	src/main/scala/ir/transforms/Simp.scala
… list of IRs. Also, Creates an endpoint to send a procedure name mapping with line stariting numbers through the API
…s nodes in the Minimap and makes it pannable. Reverses the order of epochs
…ow__node not to be updated when custom-flow-node is updated.
@Jesseable
Copy link
Collaborator Author

Just a brief update at this point in time for those watching this MR.
I have implemented a new file upload feature for custom logo images and responded to a few of the quick comments. I will have a bit more time on Tuesday and Friday where I will respond to more comments and add some more functionality. I'll add a final update on Friday before I leave for a month of holidays.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 16, 2025

scalafmt check passed.

last updated at 55408f7 (logs).

@katrinafyi
Copy link
Member

@Jesseable to link to external documentation, you should add it here

val defaultExternals = Seq(
".*/scala/.*::scaladoc3::https://scala-lang.org/api/3.3_LTS/",
".*/java/.*::javadoc::https://docs.oracle.com/en/java/javase/17/docs/api/java.base/",
".*/com/google/protobuf.*::javadoc::https://protobuf.dev/reference/java/api-docs/",
)

before the :: is a regex matching the package path with / instead of ..

@katrinafyi
Copy link
Member

But also, if this is the same problem as before, it might not be fixed by that.

The old problem was caused by inheriting a scaladoc comment with a broken reference. This was fixed by 6fa5ec4. With CommandIOApp, it's harder because the run method is marked final so we can't override it with a different scaladoc comment.

I'd just ignore this docs error for now and let it fail. Really, it's a defect in cats-effect.

@Jesseable
Copy link
Collaborator Author

Thanks, this problem has been annoying me. Is there a way to run this test locally, how can I run it using mill? I've tried ./mill basilmill?

@katrinafyi
Copy link
Member

If you run ./mill docJar, it should show you the warning (you might have to make a code change so it recompiles). The check in CI is just making sure there are no warnings in that output.

I've filed a bug with cats https://www.github.com/typelevel/cats-effect/issues/4532 (congratulations on your second Scala ecosystem bug).

Jesse Graf added 2 commits December 17, 2025 09:54
…t and decline-effect to hopefully solve build-doc warning
…pping for cats-effect and decline-effect to hopefully solve build-doc warning
@Jesseable
Copy link
Collaborator Author

Okay, I've just left it as is with 4 tests failing. I'll try to respond to all the final comments here on Friday. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants