[FIX] travis2docker: don't overwrite existing keys #225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When granting access to SSH keys by adding the same public key to the `authorized_keys` file, the existing file was being overwritten, because the mode "w" was being used instead of "a". This is the equivalent of using `>` instead of `>>` in shell. To solve this, the "a" mode is now used.
Contributor
Author
|
What do you think about this change? Regards, |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #225 +/- ##
==========================================
+ Coverage 80.61% 80.65% +0.03%
==========================================
Files 7 7
Lines 614 615 +1
Branches 113 91 -22
==========================================
+ Hits 495 496 +1
Misses 86 86
Partials 33 33 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When granting access to SSH keys by adding the same public key to the
authorized_keysfile, the existing file was being overwritten, because the mode "w" was being used instead of "a". This is the equivalent of using>instead of>>in shell.To solve this, the "a" mode is now used.