Skip to content

♻️ Make Permit2 enabled by default #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Vectorized merged 2 commits into from
Jan 15, 2025
Merged

♻️ Make Permit2 enabled by default #147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
585c075
Make Permit2 enabled by default, cuz devs are left-curved
Vectorized Jan 15, 2025
043a69d
T
Vectorized Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/DN404.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,8 @@ abstract contract DN404 {

/// @dev The canonical Permit2 address.
/// For signature-based allowance granting for single transaction ERC20 `transferFrom`.
/// To enable, override `_givePermit2DefaultInfiniteAllowance()`.
/// Enabled by default. In Permit2 we trust.
/// To disable, override `_givePermit2DefaultInfiniteAllowance()`.
/// [Github](https://github.com/Uniswap/permit2)
/// [Etherscan](https://etherscan.io/address/0x000000000022D473030F116dDEE9F6B43aC78BA3)
address internal constant _PERMIT2 = 0x000000000022D473030F116dDEE9F6B43aC78BA3;
Expand Down Expand Up @@ -450,13 +451,13 @@ abstract contract DN404 {

/// @dev Whether Permit2 has infinite allowances by default for all owners.
/// For signature-based allowance granting for single transaction ERC20 `transferFrom`.
/// To enable, override this function to return true.
/// To disable, override this function to return false.
///
/// Note: The returned value SHOULD be kept constant.
/// If the returned value changes from false to true,
/// Note: The returned value SHOULD be kept constant after tokens have been minted.
/// If the returned value changes from false to true and vice-versa,
/// it can override the user customized allowances for Permit2 to infinity.
function _givePermit2DefaultInfiniteAllowance() internal view virtual returns (bool) {
return false;
return true;
}

/// @dev Returns checks if `sender` is the canonical Permit2 address.
Expand Down
11 changes: 8 additions & 3 deletions src/DN420.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,8 @@ abstract contract DN420 {

/// @dev The canonical Permit2 address.
/// For signature-based allowance granting for single transaction ERC20 `transferFrom`.
/// To enable, override `_givePermit2DefaultInfiniteAllowance()`.
/// Enabled by default. In Permit2 we trust.
/// To disable, override `_givePermit2DefaultInfiniteAllowance()`.
/// [Github](https://github.com/Uniswap/permit2)
/// [Etherscan](https://etherscan.io/address/0x000000000022D473030F116dDEE9F6B43aC78BA3)
address internal constant _PERMIT2 = 0x000000000022D473030F116dDEE9F6B43aC78BA3;
Expand Down Expand Up @@ -435,9 +436,13 @@ abstract contract DN420 {

/// @dev Whether Permit2 has infinite ERC20 allowances by default for all owners.
/// For signature-based allowance granting for single transaction ERC20 `transferFrom`.
/// To enable, override this function to return true.
/// To disable, override this function to return false.
///
/// Note: The returned value SHOULD be kept constant after tokens have been minted.
/// If the returned value changes from false to true and vice-versa,
/// it can override the user customized allowances for Permit2 to infinity.
function _givePermit2DefaultInfiniteAllowance() internal view virtual returns (bool) {
return false;
return true;
}

/// @dev Returns checks if `sender` is the canonical Permit2 address.
Expand Down
Loading