Changes in tranforms #356
Open
Changes in tranforms #356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now Compose has a probability of 0.5 by default cause very unintuive behavior. I propose to replace to 1 by default with the option to change it.
Aurelien-VB
changed the title
Aurelien-VB
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this merge is mostly to fix unintuitive things in tranforms.
First, base probability for random select and random flip is set to 0.5. I also change the way it was done because the old way was overwritten by the inherited class.
I also rework the ResizeWithApectRatio function so that it works as described.
I removed the max_size argument as it wasn't making much sense to me. (If the largest side is equal to size then its impossible that something will be larger).
In case the max_size argument is used somewhere I recommend to just remove sizes larger than max_size.