Massively improve Dice Stats performance #154
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xperiment this means that we don't build up a bunch of closures, we just build this map straight away means we have to create a bunch of alternative implementations for basic functions, but that's ok.
…annot endlessly recurse also use a list instead of recursive maybes for DieOps
…re as dice we show and parse back!
…efficient dice stats
L0neGamer
force-pushed
the
experiment-experiments
branch
from
839d3d8 to
a0cf462
Compare
Collaborator
Author
|
Line 189 in dice stats, when we combine the Endos, is incorrect because of the order of the function applications. This will result in the modifications going in the wrong order, so I will need to fix this and verify it with tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of refactors, but the main part of this PR is using a sorted list instead of an unsorted list for a key in the distributions, which massively reduces on the number of realities we have to keep in mind.
I also add a test to verify that all dice we can show, we can parse.