Warning logging and handling #62
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6f47e43.
Contributor
Author
|
This change was on the #41 (report card branch), but unrelated to that work. |
sam-watttime
requested review from
jcofield and
xginn8
and removed request for
xginn8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces printed warnings with logging, along with a custom WattTimeAPIWarning class for future portability.
In addition to logging warnings, warnings are also stored in a class attribute, so that they can be referenced programmatically. This is helpful for large pulls, which may result in multiple warnings (e.g. MISSING_DATA) to make these easier to track and remedy.
In addition, 500 warnings are retried up to three times, as these warnings (although rare) can be intermittently caused by large historical data requests and usually remedy themselves with subsequent retries.