Skip to content

Conversation

@ginyai
Copy link

@ginyai ginyai commented Sep 25, 2018

Check if the binging is null before get soul network.
Check the result of syphonAndDamage before SigilBloodLight and SigilTransposition work.

@TehNut
Copy link
Collaborator

TehNut commented Sep 25, 2018

In what cases are these actually problems? By the time any of this is called, there should be a binding available.

@ginyai
Copy link
Author

ginyai commented Sep 26, 2018

https://gist.github.com/ginyai/52d413be10a456d6e0207dbd5e9f235e
Sometimes this happens, but I cannot find out why.
On the other hand, others can cancel the ItemBindEvent to deny the binding.

@keraldi
Copy link
Collaborator

keraldi commented Sep 26, 2018

Did you ever bind a blood orb (created a soul network) when doing that?

@ginyai
Copy link
Author

ginyai commented Sep 26, 2018

@Iorce I did. And I think it is irrelevant to the exception.

@keraldi keraldi changed the title Fix NullPointerException if no binging. Fix NullPointerException if no binding. Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants