Skip to content

Conversation

@TUsama
Copy link
Contributor

@TUsama TUsama commented Aug 3, 2021

Due to the pachoulii load method, the guide book cannot be translated unless you use the i18n key. So I patch it.

@VT-14
Copy link
Collaborator

VT-14 commented Aug 3, 2021

This is similar to #1798, but I think that got ignored because WayofTime was busy.

en_us.json is made using a Data Generator. In order for the language file change to stay around, the changes also have to be made in src/main/java/wayoftime/bloodmagic/common/data/GeneratorLanguage.java.

Notes for potential translators:

  1. The "patchouli.bloodmagic.(etc)" translation keys are planned to be moved to "guide.patchouli.bloodmagic.(etc)" keys in the near future. Any portion of an Entry generated via code should work with translations set there.

  2. Not using the language files for the actual Patchouli Entries (book.json's i18n option, default false) is an intentional decision. It would make working with the book far more tedious (reload all resources every time you change an entry vs. just reloading the book), and changing language will almost certainly lengthen or contract text to the point where page formatting would have to change. Patchouli's default method of translations is to have translated versions of the book in their own folders (same level as the en_us folder). The en_us version is the master, and translations can replace those entries.

@TUsama
Copy link
Contributor Author

TUsama commented Aug 4, 2021

Do you mean that I should add the keys at there?

@VT-14
Copy link
Collaborator

VT-14 commented Aug 4, 2021

Yup.

Don't worry about the patchouli.bloodmagic ones yet. I'll change those sometime after these changes are pulled.

@TUsama
Copy link
Contributor Author

TUsama commented Aug 4, 2021

sorry for that😓

@WayofTime WayofTime merged commit f395b07 into WayofTime:1.16.3 Aug 6, 2021
@WayofTime
Copy link
Owner

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants