Move stuff to API #2160
Move stuff to API #2160
Conversation
There was a problem hiding this comment.
I wonder if this needs more suitable class name
There was a problem hiding this comment.
SoulNetworkBinding, SoulNetworkLink, BoundPlayer
There was a problem hiding this comment.
Dont think this package belongs in API.
There was a problem hiding this comment.
it might once the "real" rituals are done. might be a premature move though
There was a problem hiding this comment.
Exposing Util classes to API might not be a great idea. We probably don't want people to poke around it
There was a problem hiding this comment.
I was thinking it might be useful for things that are common in "ritual effects" to go there so addons can make use of it. the lightning strike, creating a predictable fake player for rituals doing stuff, interacting with ranges (though that should be on the range classes directly I think)
Any tailored thing would go with the ritual effect it belongs to directly
There was a problem hiding this comment.
What happened to this class?
There was a problem hiding this comment.
they arent actually the sources but the damage types, renamed because of it and moved to api
2 participants
moved stuff I think should be in /api there
not sure how to do something similar with:
I also think at least parts of LivingHelper should be in api, but there stuff thats just there to make the effects work probably arent among them. Potentially split into "make it work" and "stuff you might wanna call from 'outside'".
Another thing is items/blocks etc. might be nice to have access to those in api so add-ons dont need to go look up the name. Potentially put the resource locations for those somewhere in api (and then use those to give the name to the deferred register? sounds halfway stupid to me but its an idea)
@dphaldes (less about code since its just renaming and moving stuff, more about the things mentioned above)