Recyclerview with header #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octave08
reviewed
Aug 31, 2017
| * Created by lf_wannabe on 27/08/2017. | ||
| */ | ||
| abstract class BaseViewHolder<T : Any>(itemView: View) : RecyclerView.ViewHolder(itemView) { | ||
| abstract class BaseViewHolder<H, T>(itemView: View) : RecyclerView.ViewHolder(itemView){ |
Contributor
There was a problem hiding this comment.
H, T를 RealmObject로 사용하고 있기 때문에 명시해 주는 것이 좋을 것 같아요.
octave08
reviewed
Aug 31, 2017
|
|
||
| private val HEADER_TYPE: Int = 0 | ||
| private val ITEM_TYPE: Int = 1 | ||
| abstract class ListAdapterWithHeader(val activity: FragmentActivity, |
Contributor
There was a problem hiding this comment.
T : RealmObejct, VH : RecyclerView.ViewHolder를 generic으로 추가해서 사용해주세요.
octave08
reviewed
Sep 2, 2017
Contributor
octave08
left a comment
octave08
left a comment
There was a problem hiding this comment.
전체적으로 불필요한 주석은 삭제해주시면 마무리 될것 같습니다.
| } | ||
| } | ||
|
|
||
| // override fun onCreateViewHolder(parent: ViewGroup, viewType: Int): RecyclerView.ViewHolder = |
| */ | ||
| class BaseApplication: Application() { | ||
|
|
||
| // companion object { |
| super.onCreate() | ||
| Realm.init(this) | ||
|
|
||
| // realmConfig = RealmConfiguration.Builder(this).build() |
Contributor
There was a problem hiding this comment.
마찬가지로 불필요한 주석은 지워주시기 바랍니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
어댑터의 추상화를 위한 구조변경 - 클릭리스너 부분 마무리작업만 하면 될듯