Fix read access for 16bit timer counter registers. #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To get meaningful reading, we must read the low byte first, so the MCU saves the correct high byte value in the counter's temporary register (see eg. section 14.2 of the 32u4 datasheet).
Author
|
Tested on my 32u4 board, on a project where I emulate several clocks on a single timer, and thus have to save/restore the timer state. Current getCounter() method just does not work. I hope all AVR8 mcu's share the same behaviour. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To get meaningful reading, we must read the low byte
first, so the MCU saves the correct high byte value in
the counter's temporary register (see eg. section 14.2
of the 32u4 datasheet).