Skip to content

Conversation

@yeonjin719
Copy link
Member

🚨 관련 이슈

#126

✨ 변경사항

  • 🐞 BugFix Something isn't working
  • 💻 CrossBrowsing Browser compatibility
  • 🌏 Deploy Deploy
  • 🎨 Design Markup & styling
  • 📃 Docs Documentation writing and editing (README.md, etc.)
  • ✨ Feature Feature
  • 🔨 Refactor Code refactoring
  • ⚙️ Setting Development environment setup
  • ✅ Test Test related (storybook, jest, etc.)

✏️ 작업 내용

  • 선택 취소 추가
  • default current 페이지 수정
  • 리셋 기능 추가

😅 미완성 작업

  • Task1

📢 논의 사항 및 참고 사항

@yeonjin719 yeonjin719 self-assigned this Aug 16, 2025
@yeonjin719 yeonjin719 linked an issue Aug 16, 2025 that may be closed by this pull request
1 task
@coderabbitai
Copy link

coderabbitai bot commented Aug 16, 2025

Caution

Review failed

The pull request is closed.

Summary by CodeRabbit

  • New Features
    • 단일 선택형 검색 필터에서 선택된 옵션을 다시 클릭하면 해제(값 초기화)할 수 있습니다.
    • 상단에 “필터 초기화” 컨트롤이 추가되어 한 번에 모든 필터를 리셋할 수 있습니다.
    • 검색 필터 액션이 “필터 초기화”와 “검색 필터” 두 개의 컨트롤로 구성되어 사용성이 향상되었습니다.
    • 데이트 코스 찾기 페이지의 기본 페이지 인덱스를 1로 조정하여 페이지 이동 흐름을 개선했습니다.

Walkthrough

단일 선택 옵션(‘choice’)에서 동일 옵션 클릭 시 선택 해제 토글을 추가했고, 필터 초기화(reset) 기능을 페이지 헤더에 도입했습니다. 필터 옵션의 onChange는 null을 허용하도록 타입이 확장되었습니다. FindDateCourse의 초기 페이지 인덱스는 1로 변경되었습니다.

Changes

Cohort / File(s) Summary
단일 선택 토글 로직
src/components/dateCourse/dateCourseSearchFilterOption.tsx
isSelected 도입, DateCourseOptionButtonisSelected 전달. 클릭 시 onChange(isSelected ? null : apiValue!)로 변경하여 동일 항목 클릭 시 해제 가능.
페이지 헤더: 필터 초기화 UI 추가
src/pages/dateCourse/CoursePage.tsx, src/pages/dateCourse/FindDateCourse.tsx
useFilterStore에서 reset 사용. 헤더에 “필터 초기화” 컨트롤 추가(클릭 시 reset() 호출). FindDateCourse 초기 페이지 인덱스 0 → 1.
타입 업데이트
src/types/dateCourse/dateCourse.ts
TDateCourseSearchFilterOption.onChange 시그니처를 `(value: string

Sequence Diagram(s)

sequenceDiagram
  participant U as User
  participant C as DateCourseSearchFilterOption (choice)
  participant P as Parent(onChange)

  U->>C: 옵션 클릭
  C->>C: isSelected = (value === apiValue)
  alt 이미 선택됨
    C->>P: onChange(null)  // 선택 해제
  else 미선택
    C->>P: onChange(apiValue)
  end
Loading
sequenceDiagram
  participant U as User
  participant Page as Course/FindDateCourse
  participant Store as useFilterStore
  participant UI as Filter UI

  U->>Page: "필터 초기화" 클릭
  Page->>Store: reset()
  Store-->>UI: 필터 상태 초기값으로 변경
  UI-->>Page: 상태 반영 및 필요한 재조회 트리거
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 503e0fe and d2bad53.

📒 Files selected for processing (4)
  • src/components/dateCourse/dateCourseSearchFilterOption.tsx (1 hunks)
  • src/pages/dateCourse/CoursePage.tsx (2 hunks)
  • src/pages/dateCourse/FindDateCourse.tsx (2 hunks)
  • src/types/dateCourse/dateCourse.ts (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@yeonjin719 yeonjin719 merged commit 0606f0e into develop Aug 16, 2025
2 of 3 checks passed
@yeonjin719 yeonjin719 deleted the bugfix/#126 branch August 16, 2025 15:33
@coderabbitai coderabbitai bot mentioned this pull request Aug 17, 2025
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐞 [BugFix] 에러잡기

2 participants