Import pages through navigation (part 1) #103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psrpinto
force-pushed
the
pages-import
branch
from
8eaf911 to
e9ccfc1
Compare
psrpinto
force-pushed
the
pages-import
branch
from
673f77f to
482b23d
Compare
Member
Author
|
@akirk @ashfame I'm making progress here on what comes after what is shown in the screen recording (importing each of the pages the user selected). I should have a finished version tomorrow. My goal is to build a first iteration of the flow here, we can then adapt it however is needed for the demo in other PRs. |
psrpinto
force-pushed
the
pages-import
branch
from
5a50f12 to
6681827
Compare
psrpinto
changed the title
psrpinto
force-pushed
the
pages-import
branch
from
fd7096d to
3c3610c
Compare
psrpinto
force-pushed
the
pages-import
branch
from
3c3610c to
5089e7b
Compare
psrpinto
commented
Nov 12, 2024
| setUrl( selectedPages[ pageIndex ] ); | ||
| }, [ session.id, pageIndex, navigate, selectedPages ] ); | ||
|
|
||
| return <>{ url }</>; |
Member
Author
There was a problem hiding this comment.
The next PR will implement this component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements one flow for import pages by selecting the navigation. Later, we can adapt it how we see fit, or we can implement other flows for importing pages that do it differently. This is just a starting point, any feedback you might have can be implemented.
A note on blueprints
This PR implements importing pages without relying on Blueprints. Blueprints are meant for things that would be crawled, where the user defines the structure of one thing (e.g. blog post), and we than use that to automatically import all other ones.
However, things that don't need to be crawled do not need to rely on a blueprint. Instead, the user can manually import all instances.
This PR implements page import in this manual way, where there is no automatic crawling, so no blueprints are involved. In the future we may decide that we do want to crawl pages, and if so, a new flow can be implemented that relies on blueprints.
This is only part 1
This PR was getting too large, so I figured I would ship it as is, and there will be a second one that completes the flow. This PR stops after the user selected the pages (see screen recording), the next PR will have the user iteratively import all selected pages, one by one.
Summary of changes
LinkFieldand a navigation parser. Takes a<ul>...<ul/>and returns an array ofLinkField<ul>./ui/import/pagesScreen recording
Screen.Recording.2024-11-12.at.15.58.41.mov