-
Notifications
You must be signed in to change notification settings - Fork 381
[PHP] Refactor files following up on split PHP.wasm packages #3085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PHP] Refactor files following up on split PHP.wasm packages #3085
Conversation
1b4f2ea to
221160f
Compare
95672ae to
c7f5584
Compare
c7f5584 to
d0feb4f
Compare
|
Alright, alright, alright! This is now ready for review! |
|
@bgrgicak As this pull request fixes a bug in PHP.wasm Web and PHP.wasm Compile, I think we could maybe review this pull request this week? But I get a hard time listing the file changes since there are a lot [ Especially .so, .wasm, ... files ]. This pull request is mostly deleting obsolete files, rewriting code to keep consistency and fixing bugs. |
…the current directory path in PHP.wasm Node
bgrgicak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing the feedback @mho22
|
Thank you for taking the time to review my pull requests! |
Motivation for the change, related issues
This pull request refactors code in PHP compilation / shared libraries and PHP.wasm Node / PHP.wasm web to keep consistency. This follows up on the split PHP.wasm packages into per PHP version packages pull request.
Implementation details
icudt74l.jsandicudt74.datfilespublic/shareddirectory insideextensions/intlin consistency with thenodestructure [ Bug ]publicdirectory insidewebvite-external-dynamic-importsVite plugin. Not needed anymore.xdebugdirectory insideextensionsdirectory alongsideintlcurrentDirPathinphp.jsfiles similarly to thenode-builds/*/src/index.tsfiles.Testing Instructions (or ideally a Blueprint)
CI