Skip to content

Conversation

@mho22
Copy link
Collaborator

@mho22 mho22 commented Dec 29, 2025

Motivation for the change, related issues

This pull request refactors code in PHP compilation / shared libraries and PHP.wasm Node / PHP.wasm web to keep consistency. This follows up on the split PHP.wasm packages into per PHP version packages pull request.

Implementation details

  • Removed obsolete icudt74l.js and icudt74.dat files
  • Moved public/shared directory inside extensions/intl in consistency with the node structure [ Bug ]
  • Removed obsolete public directory inside web
  • Removed unused vite-external-dynamic-imports Vite plugin. Not needed anymore.
  • Moved Node xdebug directory inside extensions directory alongside intl
  • Simplified shared libraries build commands in consistency with PHP build
  • Simplified PHP build commands
  • Cloned PHP repository based on the tag name instead of the branch name [ e.g. branch 8.2.30 doesn't exist while tag 8.2.30 does ] [ Bug ]
  • Added currentDirPath in php.js files similarly to the node-builds/*/src/index.ts files.
  • Rebuilt shared libraries
  • Rebuilt PHP

Testing Instructions (or ideally a Blueprint)

CI

@mho22 mho22 force-pushed the refactor-files-following-up-on-per-php-version-packages branch 4 times, most recently from 1b4f2ea to 221160f Compare December 30, 2025 19:17
@mho22 mho22 marked this pull request as ready for review December 30, 2025 20:06
@mho22 mho22 marked this pull request as draft December 30, 2025 20:08
@mho22 mho22 force-pushed the refactor-files-following-up-on-per-php-version-packages branch 2 times, most recently from 95672ae to c7f5584 Compare December 31, 2025 09:40
@mho22 mho22 force-pushed the refactor-files-following-up-on-per-php-version-packages branch from c7f5584 to d0feb4f Compare December 31, 2025 11:07
@mho22
Copy link
Collaborator Author

mho22 commented Dec 31, 2025

Alright, alright, alright! This is now ready for review!

@mho22 mho22 marked this pull request as ready for review December 31, 2025 13:51
@mho22
Copy link
Collaborator Author

mho22 commented Jan 5, 2026

@bgrgicak As this pull request fixes a bug in PHP.wasm Web and PHP.wasm Compile, I think we could maybe review this pull request this week? But I get a hard time listing the file changes since there are a lot [ Especially .so, .wasm, ... files ].

This pull request is mostly deleting obsolete files, rewriting code to keep consistency and fixing bugs.

Copy link
Collaborator

@bgrgicak bgrgicak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the feedback @mho22

@mho22 mho22 merged commit 74446e7 into trunk Jan 6, 2026
33 checks passed
@mho22 mho22 deleted the refactor-files-following-up-on-per-php-version-packages branch January 6, 2026 07:53
@mho22
Copy link
Collaborator Author

mho22 commented Jan 6, 2026

Thank you for taking the time to review my pull requests!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants