forked from ethereum/go-ethereum
-
Notifications
You must be signed in to change notification settings - Fork 69
consensus: use signer pubkey to check for unique signatures, close XFN-03 #1643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamin202410
approved these changes
Nov 4, 2025
gzliudan
reviewed
Nov 5, 2025
gzliudan
reviewed
Nov 5, 2025
gzliudan
reviewed
Nov 5, 2025
gzliudan
reviewed
Nov 5, 2025
gzliudan
reviewed
Nov 5, 2025
gzliudan
reviewed
Nov 9, 2025
gzliudan
reviewed
Nov 9, 2025
benjamin202410
requested changes
Nov 10, 2025
Collaborator
benjamin202410
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
leave some comments
add input validation and early return
liam-icheng-lai
approved these changes
Nov 10, 2025
benjamin202410
approved these changes
Nov 10, 2025
gzliudan
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
use signer pubkey to check for unique signatures
ref audit ticket: XFN-03
Types of changes
What types of changes does your code introduce to XDC network?
Put an
✅in the boxes that applyImpacted Components
Which part of the codebase this PR will touch base on,
Put an
✅in the boxes that applyChecklist
Put an
✅in the boxes once you have confirmed below actions (or provide reasons on not doing so) that