core, eth, miner: 4844 blob transaction pool #26940 #1911
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
gzliudan
requested review from
AnilChinchawale,
anunay-xin,
benjamin202410,
liam-lai and
wanwiset25
There was a problem hiding this comment.
Pull request overview
This PR integrates EIP-4844 blob transaction pool functionality by introducing a modular transaction pool architecture with specialized subpools. The main changes include refactoring the legacy transaction pool into a subpool implementation and creating a new aggregator pool that manages multiple transaction type-specific subpools.
Key changes:
- Introduced
SubPoolinterface andLazyTransactionwrapper for deferred transaction resolution - Refactored existing transaction pool code from
txpoolpackage tolegacypoolpackage - Created new aggregator
TxPoolthat manages multiple subpools and routes transactions accordingly
Reviewed changes
Copilot reviewed 41 out of 41 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| miner/worker.go | Updated to use LazyTransaction wrapper and new ordering functions |
| miner/ordering_test.go | Added comprehensive tests for transaction ordering with lazy loading |
| miner/ordering.go | Implemented new transaction ordering logic with miner fee calculations |
| core/txpool/txpool.go | Replaced legacy pool with new aggregator pool managing subpools |
| core/txpool/subpool.go | Defined SubPool interface and LazyTransaction structure |
| core/txpool/errors.go | Extracted error definitions to shared package |
| core/txpool/validation.go | Added UsedAndLeftSlots validation callback |
| core/txpool/txpool_test.go | Moved and updated tests to legacypool package |
| eth/backend.go | Updated to instantiate new modular pool architecture |
| Multiple files | Package renames from txpool to legacypool |
Comments suppressed due to low confidence (1)
miner/ordering.go:1
- Corrected 'if' to 'it' for grammatical accuracy.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| return fmt.Errorf("%w: balance %v, queued cost %v, tx cost %v, overshot %v", core.ErrInsufficientFunds, balance, spent, cost, new(big.Int).Sub(need, newBalance)) | ||
| } | ||
| // Transaction takes a new nonce value out of the pool. Ensure it doesn't | ||
| // overflow the number of permitted transactions from a single accoun |
There was a problem hiding this comment.
Corrected spelling of 'accoun' to 'account'.
| // overflow the number of permitted transactions from a single accoun | |
| // overflow the number of permitted transactions from a single account |
2 participants
Proposed changes
Ref: ethereum#26940
Types of changes
What types of changes does your code introduce to XDC network?
Put an
✅in the boxes that applyImpacted Components
Which part of the codebase this PR will touch base on,
Put an
✅in the boxes that applyChecklist
Put an
✅in the boxes once you have confirmed below actions (or provide reasons on not doing so) that