This repository was archived by the owner on Jun 6, 2022. It is now read-only.
Fix for issue #30 and #33 #35
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Minor remark: try not to mix style/indentation fixes in PR's with features as this obscures the actual feature implementation in the diff |
Contributor
Author
|
My IDE's autostyling (or w/e it's called) did that, and I didn't realise it until the changes were already made and I was about to commit my code. |
As discussed with iasoon on slack
Contributor
Author
|
Above commit seems to fix #32 in my browser, but I have absolutely no clue why. |
Member
|
I don't know how or why, but somehow this PR was overlooked and the issues got fixed in other commits. Your fix for #30 is a lot nicer though. Do you want to rebase this? (Note that the code has been ported to Coffeescript in the meantime.) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First time using ruby. Please do review, although these commits are minor changes.