Return add command errors rather than log + swallowing them #30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #28
Replicated issue before the fix against google.com:
Confirmed after re-building that semantifly works as expected against bing.com
Confirmed postgres index table contains the complete bing metadata (with the bad google.com entry from pre-fix commands):
Subcommand tests still passing after change (note I had to update the echo.jsontest.com calls in the tests to api.github.com instead as I was having DNS issues with echo.jsontest.com, unsure if this is a my-network thing though so haven't included that change in the PR):