Changes to PersistentSingleton.cs #33
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kiryonn
commented
Apr 22, 2025
Kiryonn
commented
- Only check and execute the unparenting if the singleton is to survive.
- Removed "TryGetInstance" which was redundant.
added 2 commits
April 22, 2025 10:45
This property should just return instance directly (if instance is not null return instance else return null). But since there's already a public static getter "Instance" that does what this property is expected to return, there's no need for it.
Author
|
For some reasons the last empty line was removed on the commit. I personally prefer when it's there. |
Author
|
Also it might be a good idea to mark the Singletons as |
adammyhre
force-pushed
the
master
branch
3 times, most recently
from
149bf61 to
d162ee9
Compare
adammyhre
force-pushed
the
master
branch
3 times, most recently
from
d3d8cd7 to
af213d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.