chore: better codesandbox error #9273
Conversation
|
Build successful! 🎉 |
| ToastQueue.negative('Failed to create CodeSandbox, make sure you are logged in to CodeSandbox. If you are already logged in, logout and log back in.'); | ||
| } |
There was a problem hiding this comment.
I kind of like the idea of this being a Dialog. It's less harsh and there's more room to to explain what the user needs to do. And the primary action could do another check (with pending state) and open the link if it passes.
|
This appears to be a non-viable solution. When we use the form approach the users authentication cookies are included because it's the same domain. When I try to use the fetch, I can't include the auth because it's cross-origin. I could try loading an hidden iframe of codesandbox potentially and if it loads vs errors, we might be able to determine if the user is logged in, but even that may not work. I think we should provide more info in a dialog that opens to confirm that you mean to leave the page though, that's the simplest solution, though does require one more click. |
|
Build successful! 🎉 |
| {({close}) => (<> | ||
| <Heading slot="title">Create a CodeSandbox</Heading> | ||
| <Content> | ||
| <p>This will open a new tab with a CodeSandbox containing this example. If you see a 403 error, please log in to CodeSandbox and try again. If you are already logged in, please logout and log back in and then try again.</p> |
There was a problem hiding this comment.
Maybe mention Anonymous users are not allowed to create devboxes. instead of 403 here.
There was a problem hiding this comment.
+1 to this, or maybe something more generic like "If you see an error"/"If a sandbox isn't created automatically..." in case the error message changes in the future
|
Build successful! 🎉 |
|
Build successful! 🎉 |
devongovett
left a comment
devongovett
left a comment
There was a problem hiding this comment.
Hopefully they fix this in the future and we can remove this but seems fine for now
Closes
Unauthenticated users cannot create a devbox, because we are not codesandbox and they provide no auth api, I cannot tell if a user is capable of creating a codesandbox devbox. This will warn users that they need to be logged in, and if it still didn't work, how to fix that.
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: