Version Packages #631
Merged
Version Packages #631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Install remark, remark-cli, remark-gfm, and remark-github - Update lint-staged to use remark for markdown files instead of prettier - Remark provides better GFM support and preserves HTML elements like <details> - Fixes formatting issues with collapsible sections in CHANGELOG.md
Member
Author
Run report for c8599786Total time: 1m 1s | Comparison time: 1m 57s | Estimated savings: 56.7s (48.1% faster)
Expanded report
Touched files |
github-actions
bot
force-pushed
the
changeset-release/main
branch
from
2316ce3 to
4a1fcfc
Compare
The tokens/ directory in docs/s2-tokens-viewer is automatically generated by the prepare script from the workspace @adobe/spectrum-tokens package. These files should not be tracked in git as they are regenerated on every pnpm install and are properly generated during CI/CD deployment.
GarthDB
force-pushed
the
changeset-release/main
branch
from
4a1fcfc to
63a8720
Compare
- Remove duplicate s2-tokens-viewer:export call (project is named 'viewer') - Add InstallWorkspaceDeps dependency to viewer:export task to ensure tokens directory is generated by prepare script before export runs
The export task was failing in CI because the tokens/ directory wasn't being generated. The pnpm prepare script only runs during npm install, which isn't explicitly part of the task dependency chain. Added an explicit prepare task that: - Depends on tokens:build to ensure tokens are generated - Copies tokens from node_modules to local tokens/ directory - Is a dependency of the export task This ensures tokens/ exists before export tries to copy it.
The clean task was failing in CI because it assumed ../../site existed. Updated to create the parent site directory before attempting to remove and recreate the s2-tokens-viewer subdirectory.
Changed viewer:export output from /site/ to /site/s2-tokens-viewer/ to prevent caching conflicts with site:export task. Both tasks were claiming the entire /site/ directory, causing moon to restore conflicting cached states. This ensures each task only manages its own subdirectory within site/.
remark-github incorrectly interpreted @13.x.x version numbers as GitHub user mentions, breaking links like: - Before: [@adobe/spectrum-tokens](url)@13.16.0 - Broken: [@adobe/spectrum-tokens](url)[@13](github.com/13).16.0 - Fixed: [@adobe/spectrum-tokens](url)@13.16.0 Also updated .lintstagedrc.js to exclude CHANGELOG.md files from remark processing to prevent this issue in the future.
…-data Updated all CHANGELOG.md and README.md files to reflect the repository rename from adobe/spectrum-tokens to adobe/spectrum-design-data. This ensures all commit links and references point to the correct repository. Also fixed additional remark-github broken links (@5.x.x versions). - 21 files updated - 271 URL references corrected
Updated all CHANGELOG.md files to link package versions directly to their GitHub release notes instead of the repository homepage. Before: [**@adobe/spectrum-tokens**](repo)@13.16.0 After: @adobe/spectrum-tokens@[13.16.0](repo/releases/tag/...) This provides developers direct access to release notes when reviewing dependency updates. Regex: s/\[\*\*(@adobe\/[^*]+)\*\*\]\(URL\)@(VER)/\1@[VER](URL/releases/tag/.../g
- Updated git clone URL from spectrum-tokens to spectrum-design-data - Fixed tokens path to point to s1-legacy branch (appropriate for S1 visualizer) - Updated directory navigation path to match new repo name
…esign-data Updated the token-diff-generator tests and source code to use the new repository name adobe/spectrum-design-data instead of adobe/spectrum-tokens. Changes: - Updated defaultRepo constant in file-import.js - Updated error message repository fallback in file-import.js - Updated test expectations in fileImportMain.test.js (3 tests) - Updated test expectations in fileImportRefactored.test.js (2 tests) This fixes the failing CI tests that were trying to fetch from the old repository URL and receiving 404 errors. All 260 tests now pass.
Member
Author
Summary of FixesThis PR has been updated to resolve merge conflicts and fix CI failures. Key ChangesMerge Conflicts
CI/CD Fixes
Repository Migration Updates
Test Fixes
Documentation Improvements
All CI checks should now pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
site@0.1.1
Patch Changes
#630
04cf6ebThanks @GarthDB! - Update docs/site to use workspace version of @adobe/spectrum-component-api-schemas package.The site now imports schemas directly from the package instead of using hardcoded file paths,
ensuring automatic updates with each published release. Added schema version display on all
site pages.
#633
662285aThanks @GarthDB! - fix: update GitHub Pages site asset paths to spectrum-design-dataUpdated Next.js configuration to load assets from the correct
/spectrum-design-data/ path instead of the old /spectrum-tokens/ path.
This fixes font loading and other asset issues on the deployed site.