Skip to content

Conversation

@vincentfretin
Copy link
Contributor

@vincentfretin vincentfretin commented Dec 16, 2025

Description:

Set timeout mechanism and loading screen earlier at interactive state so we see the loading screen while images are loading.
That was a regression since 0d97218 where we changed everything to wait on complete state that includes DOM ready and resources like images loaded.

Changes proposed:

  • Implements connectedCallback for a-assets to wait for interactive and similar in a-scene to set the renderer and loading screen earlier.

PR done with the help of Claude Code with Opus 4.5

… so we see the loading screen while images are loading
@vincentfretin
Copy link
Contributor Author

You can test it on the 360 image example examples/boilerplate/panorama/index.html with Chrome network tab set to Slow 4G for example.

@vincentfretin
Copy link
Contributor Author

Note that if the timeout is hit, the loading screen will still show until all images are loaded (triggering the readyState complete), then the loading screen hide and we can still have some a-asset-item elements downloading.
It doesn't make sense to hide the loading screen before readyState complete anyway, the page will be just white, because all entities and components are loaded only in readyState complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants