feat(runtime): add support loading configuration from .env file and environment variables #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
Collaborator
xuehuitian45
left a comment
xuehuitian45
left a comment
There was a problem hiding this comment.
The current code looks good to me. It can be merged after making the following two changes:
- Please remove the Lombok syntax used in AgentApp, as our coding standards do not allow the use of Lombok.
- Please document the new functionality you've added in the cookbook, so that users can become aware of the new feature and understand how to use it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/agentscope-ai/agentscope-runtime-java/issues/70